ready to move gRPC into a single services folder, time to do the changes now

client/src/components/auth/login.rs

@@ -1,14 +1,17 @@
 // src/components/auth/login.rs
+
 use crate::{
-    components::form::form::render_generic_form,
     config::colors::themes::Theme,
     state::pages::auth::AuthState,
+    components::common::dialog,
+    state::state::AppState,  // Add this import
 };
 use ratatui::{
     layout::{Alignment, Constraint, Direction, Layout, Rect, Margin},
-    style::{Color, Style},
+    style::{Style, Modifier, Color},  // Removed unused Color import
     widgets::{Block, BorderType, Borders, Paragraph},
     Frame,
+    text::Line,  // Removed unused Span import
 };
 
 pub fn render_login(
@@ -16,11 +19,13 @@ pub fn render_login(
     area: Rect,
     theme: &Theme,
     state: &AuthState,
+    app_state: &AppState,  // Add AppState parameter
+    is_edit_mode: bool,
 ) {
-    // Main login block with plain borders (matches main form style)
+    // Main container
     let block = Block::default()
         .borders(Borders::ALL)
-        .border_type(BorderType::Plain) // Matches main form style
+        .border_type(BorderType::Plain)
         .border_style(Style::default().fg(theme.border))
         .title(" Login ")
         .style(Style::default().bg(theme.bg));
@@ -32,49 +37,57 @@ pub fn render_login(
         vertical: 1,
     });
 
-    // Define field names
-    let fields = &["Username/Email", "Password"];
-
-    // Split layout for form and buttons
+    // Layout chunks
     let chunks = Layout::default()
         .direction(Direction::Vertical)
         .constraints([
-            Constraint::Min(3),  // Form area
-            Constraint::Length(1), // Error message area
-            Constraint::Length(3), // Buttons area
+            Constraint::Length(4),  // Form (2 fields + padding)
+            Constraint::Length(1),  // Error message
+            Constraint::Length(3),  // Buttons
         ])
         .split(inner_area);
 
-    // Render form with plaintext display
-    render_generic_form(
+    // --- FORM RENDERING ---
+    let input_block = Block::default()
+        .borders(Borders::ALL)
+        .border_style(if is_edit_mode {
+            Style::default().fg(theme.accent)
+        } else {
+            Style::default().fg(theme.border)
+        })
+        .style(Style::default().bg(theme.bg));
+
+    // Calculate inner area BEFORE rendering
+    let input_area = input_block.inner(chunks[0]);
+    
+    f.render_widget(input_block, chunks[0]);
+
+    // Use the canvas renderer for fields
+    crate::components::handlers::canvas::render_canvas(
         f,
-        chunks[0],
-        "Login",
+        input_area,  // Use the pre-calculated area
         state,
-        fields,
+        &["Username/Email", "Password"],
+        &state.current_field,
+        &[&state.username, &state.password],
         theme,
-        !state.return_selected, // is_edit_mode
+        is_edit_mode,
     );
 
-    // Render buttons
+    // --- BUTTONS --- (Keep this unchanged)
     let button_chunks = Layout::default()
         .direction(Direction::Horizontal)
         .constraints([Constraint::Percentage(50), Constraint::Percentage(50)])
         .split(chunks[2]);
 
-    // Login button
-    let login_style = if !state.return_selected {
-        Style::default()
-            .fg(theme.highlight)
-            .add_modifier(ratatui::style::Modifier::BOLD)
-    } else {
-        Style::default().fg(theme.fg)
-    };
-    let login_border_style = if !state.return_selected {
-        Style::default().fg(theme.accent)
-    } else {
-        Style::default().fg(theme.border)
-    };
+    // Login Button
+    let login_active = !state.return_selected;
+    let mut login_style = Style::default().fg(theme.fg);
+    let mut login_border = Style::default().fg(theme.border);
+    if login_active {
+        login_style = login_style.fg(theme.highlight).add_modifier(Modifier::BOLD);
+        login_border = login_border.fg(theme.accent);
+    }
 
     f.render_widget(
         Paragraph::new("Login")
@@ -84,24 +97,19 @@ pub fn render_login(
                 Block::default()
                     .borders(Borders::ALL)
                     .border_type(BorderType::Plain)
-                    .border_style(login_border_style),
+                    .border_style(login_border),
             ),
         button_chunks[0],
     );
 
-    // Return button
-    let return_style = if state.return_selected {
-        Style::default()
-            .fg(theme.highlight)
-            .add_modifier(ratatui::style::Modifier::BOLD)
-    } else {
-        Style::default().fg(theme.fg)
-    };
-    let return_border_style = if state.return_selected {
-        Style::default().fg(theme.accent)
-    } else {
-        Style::default().fg(theme.border)
-    };
+    // Return Button
+    let return_active = state.return_selected;
+    let mut return_style = Style::default().fg(theme.fg);
+    let mut return_border = Style::default().fg(theme.border);
+    if return_active {
+        return_style = return_style.fg(theme.highlight).add_modifier(Modifier::BOLD);
+        return_border = return_border.fg(theme.accent);
+    }
 
     f.render_widget(
         Paragraph::new("Return")
@@ -111,16 +119,29 @@ pub fn render_login(
                 Block::default()
                     .borders(Borders::ALL)
                     .border_type(BorderType::Plain)
-                    .border_style(return_border_style),
+                    .border_style(return_border),
             ),
         button_chunks[1],
     );
 
-    // Render error message if present
+    // Error message
     if let Some(err) = &state.error_message {
-        let err_block = Paragraph::new(err.as_str())
-            .style(Style::default().fg(Color::Red))
-            .alignment(Alignment::Center);
-        f.render_widget(err_block, chunks[1]);
+        f.render_widget(
+            Paragraph::new(err.as_str())
+                .style(Style::default().fg(Color::Red))
+                .alignment(Alignment::Center),
+            chunks[1],
+        );
+    }
+
+    if app_state.ui.dialog.show_dialog {
+        dialog::render_dialog(
+            f,
+            f.area(), // Use area() instead of deprecated size()
+            theme,
+            &app_state.ui.dialog.dialog_title,
+            &app_state.ui.dialog.dialog_message,
+            app_state.ui.dialog.dialog_button_active,
+        );
     }
 }

client/src/components/common.rs

@@ -2,7 +2,9 @@
 pub mod command_line;
 pub mod status_line;
 pub mod background;
+pub mod dialog;
 
 pub use command_line::*;
 pub use status_line::*;
 pub use background::*;
+pub use dialog::*;

client/src/components/common/dialog.rs

@@ -0,0 +1,101 @@
+// src/components/common/dialog.rs
+use ratatui::{
+    layout::{Constraint, Direction, Layout, Rect, Margin},
+    style::{Color, Modifier, Style},
+    widgets::{Block, BorderType, Borders, Paragraph},
+    Frame,
+    text::{Text, Line, Span}
+};
+use ratatui::prelude::Alignment;
+use crate::config::colors::themes::Theme;
+
+pub fn render_dialog(
+    f: &mut Frame,
+    area: Rect,
+    theme: &Theme,
+    title: &str,
+    message: &str,
+    is_active: bool,
+) {
+    // Create a centered rect for the dialog
+    let dialog_area = centered_rect(60, 25, area);
+
+    // Main dialog container
+    let block = Block::default()
+        .borders(Borders::ALL)
+        .border_type(BorderType::Rounded)
+        .border_style(Style::default().fg(theme.accent))
+        .title(title)
+        .style(Style::default().bg(theme.bg));
+
+    f.render_widget(&block, dialog_area);
+
+    // Inner content area
+    let inner_area = block.inner(dialog_area).inner(Margin {
+        horizontal: 2,
+        vertical: 1,
+    });
+
+    // Split into message and button areas
+    let chunks = Layout::default()
+        .direction(Direction::Vertical)
+        .constraints([
+            Constraint::Min(3),  // Message content
+            Constraint::Length(3),  // Button
+        ])
+        .split(inner_area);
+
+    // Message text
+    let message_text = Text::from(message.lines().map(|l| Line::from(Span::styled(
+        l,
+        Style::default().fg(theme.fg)
+    ))).collect::<Vec<_>>());
+    
+    let message_paragraph = Paragraph::new(message_text)
+        .alignment(Alignment::Center);
+    f.render_widget(message_paragraph, chunks[0]);
+
+    // OK Button
+    let button_style = if is_active {
+        Style::default()
+            .fg(theme.highlight)
+            .add_modifier(Modifier::BOLD)
+    } else {
+        Style::default().fg(theme.fg)
+    };
+
+    let button_block = Block::default()
+        .borders(Borders::ALL)
+        .border_type(BorderType::Plain)
+        .border_style(Style::default().fg(theme.accent))
+        .style(Style::default().bg(theme.bg));
+
+    f.render_widget(
+        Paragraph::new("OK")
+            .block(button_block)
+            .style(button_style)
+            .alignment(Alignment::Center),
+        chunks[1],
+    );
+}
+
+/// Helper function to center a rect with given percentage values
+fn centered_rect(percent_x: u16, percent_y: u16, r: Rect) -> Rect {
+    let popup_layout = Layout::default()
+        .direction(Direction::Vertical)
+        .constraints([
+            Constraint::Percentage((100 - percent_y) / 2),
+            Constraint::Percentage(percent_y),
+            Constraint::Percentage((100 - percent_y) / 2),
+        ])
+        .split(r);
+
+    Layout::default()
+        .direction(Direction::Horizontal)
+        .constraints([
+            Constraint::Percentage((100 - percent_x) / 2),
+            Constraint::Percentage(percent_x),
+            Constraint::Percentage((100 - percent_x) / 2),
+        ])
+        .split(popup_layout[1])[1]
+}

client/src/components/form/form.rs

@@ -65,47 +65,3 @@ pub fn render_form(
         is_edit_mode,
     );
 }
-
-// New generic form renderer
-pub fn render_generic_form(
-    f: &mut Frame,
-    area: Rect,
-    title: &str,
-    state: &impl CanvasState,
-    fields: &[&str],
-    theme: &Theme,
-    is_edit_mode: bool,
-) {
-    // Create form card
-    let form_card = Block::default()
-        .borders(Borders::ALL)
-        .border_style(Style::default().fg(theme.border))
-        .title(format!(" {} ", title))
-        .style(Style::default().bg(theme.bg).fg(theme.fg));
-
-    f.render_widget(form_card, area);
-
-    // Define inner area
-    let inner_area = area.inner(Margin {
-        horizontal: 1,
-        vertical: 1,
-    });
-
-    // Create main layout
-    let main_layout = Layout::default()
-        .direction(Direction::Vertical)
-        .constraints([Constraint::Min(1)])
-        .split(inner_area);
-
-    // Delegate to render_canvas
-    render_canvas(
-        f,
-        main_layout[0],
-        state,
-        fields,
-        &state.current_field(),
-        &state.inputs(),
-        theme,
-        is_edit_mode,
-    );
-}

client/src/components/intro/intro.rs

@@ -32,9 +32,9 @@ impl IntroState {
         let chunks = Layout::default()
             .direction(Direction::Vertical)
             .constraints([
-                Constraint::Percentage(35),
-                Constraint::Length(7), // Increased to accommodate 3 buttons
-                Constraint::Percentage(35),
+                Constraint::Percentage(40),
+                Constraint::Length(5), // Increased to accommodate 3 buttons
+                Constraint::Percentage(40),
             ])
             .split(inner_area);
 

client/src/lib.rs

@@ -5,6 +5,7 @@ pub mod config;
 pub mod state;
 pub mod components;
 pub mod modes;
+pub mod services;
 
 pub use ui::run_ui;
 

client/src/modes/canvas/common.rs

@@ -1,10 +1,11 @@
 // src/modes/canvas/common.rs
 
 use crate::config::binds::config::Config;
-use crate::tui::terminal::grpc_client::GrpcClient;
 use crate::tui::terminal::core::TerminalCore;
 use crate::state::pages::form::FormState;
 use crate::state::state::AppState;
+use crate::services::grpc_client::GrpcClient;
+
 use common::proto::multieko2::adresar::{PostAdresarRequest, PutAdresarRequest};
 
 /// Main handler for common core actions

client/src/modes/canvas/edit.rs

@@ -2,12 +2,11 @@
 
 // TODO THIS is freaking bloated with functions it never uses REFACTOR 200 LOC can be gone
 use crossterm::event::{KeyEvent, KeyCode, KeyModifiers};
-use crate::tui::terminal::{
-    grpc_client::GrpcClient,
-};
 use crate::config::binds::config::Config;
 use crate::state::pages::form::FormState;
 use crate::modes::canvas::common;
+use crate::services::grpc_client::GrpcClient;
+
 
 pub async fn handle_edit_event_internal(
     key: KeyEvent,

client/src/modes/canvas/read_only.rs

@@ -5,8 +5,8 @@ use crossterm::event::{KeyEvent};
 use crate::config::binds::config::Config;
 use crate::state::pages::form::FormState;
 use crate::state::pages::auth::AuthState;
+use crate::services::grpc_client::GrpcClient;
 use crate::config::binds::key_sequences::KeySequenceTracker;
-use crate::tui::terminal::grpc_client::GrpcClient;
 
 #[derive(PartialEq)]
 enum CharType {

client/src/modes/common/command_mode.rs

@@ -1,8 +1,8 @@
 // src/modes/handlers/command_mode.rs
 
 use crossterm::event::{KeyEvent, KeyCode, KeyModifiers};
-use crate::tui::terminal::grpc_client::GrpcClient;
 use crate::config::binds::config::Config;
+use crate::services::grpc_client::GrpcClient;
 use crate::state::pages::form::FormState;
 use crate::tui::controls::commands::CommandHandler;
 use crate::tui::terminal::core::TerminalCore;

client/src/modes/handlers/event.rs

@@ -3,8 +3,8 @@ use crossterm::event::Event;
 use crossterm::cursor::SetCursorStyle;
 use crate::tui::terminal::{
     core::TerminalCore,
-    grpc_client::GrpcClient,
 };
+use crate::services::grpc_client::GrpcClient;
 use crate::tui::controls::commands::CommandHandler;
 use crate::config::binds::config::Config;
 use crate::state::pages::form::FormState;

client/src/services/adresar.rs

@@ -0,0 +1 @@
+// src/services/adresar.rs

client/src/services/grpc_client.rs

@@ -1,4 +1,4 @@
-// src/tui/terminal/grpc_client.rs
+// src/services/grpc_client.rs
 
 use tonic::transport::Channel;
 use common::proto::multieko2::adresar::adresar_client::AdresarClient;
@@ -10,11 +10,17 @@ use common::proto::multieko2::table_definition::{
     table_definition_client::TableDefinitionClient,
     ProfileTreeResponse
 };
+use common::proto::multieko2::auth::{
+    auth_service_client::AuthServiceClient,
+    LoginRequest, LoginResponse
+};
 
+#[derive(Clone)]
 pub struct GrpcClient {
     adresar_client: AdresarClient<Channel>,
     table_structure_client: TableStructureServiceClient<Channel>,
     table_definition_client: TableDefinitionClient<Channel>,
+    auth_client: AuthServiceClient<Channel>,
 }
 
 impl GrpcClient {
@@ -22,11 +28,13 @@ impl GrpcClient {
         let adresar_client = AdresarClient::connect("http://[::1]:50051").await?;
         let table_structure_client = TableStructureServiceClient::connect("http://[::1]:50051").await?;
         let table_definition_client = TableDefinitionClient::connect("http://[::1]:50051").await?;
+        let auth_client = AuthServiceClient::connect("http://[::1]:50051").await?;
 
         Ok(Self {
             adresar_client,
             table_structure_client,
             table_definition_client,
+            auth_client,
         })
     }
 
@@ -65,4 +73,10 @@ impl GrpcClient {
         let response = self.table_definition_client.get_profile_tree(request).await?;
         Ok(response.into_inner())
     }
+
+    pub async fn login(&mut self, identifier: String, password: String) -> Result<LoginResponse, Box<dyn std::error::Error>> {
+        let request = tonic::Request::new(LoginRequest { identifier, password });
+        let response = self.auth_client.login(request).await?.into_inner();
+        Ok(response)
+    }
 }

client/src/services/mod.rs

@@ -0,0 +1,13 @@
+// services/mod.rs
+
+pub mod grpc_client;
+pub mod adresar;
+pub mod table;
+pub mod profile;
+pub mod auth;
+
+pub use grpc_client::*;
+pub use adresar::*;
+pub use table::*;
+pub use profile::*;
+pub use auth::*;

client/src/services/profile.rs

@@ -0,0 +1 @@
+// src/services/profile.rs

client/src/services/table.rs

@@ -0,0 +1 @@
+// src/services/table.rs

client/src/state/canvas_state.rs

@@ -9,6 +9,7 @@ pub trait CanvasState {
     fn inputs(&self) -> Vec<&String>;
     fn get_current_input(&self) -> &str;
     fn get_current_input_mut(&mut self) -> &mut String;
+    fn fields(&self) -> Vec<&str>;
 }
 
 // Implement for FormState (keep existing form.rs code and add this)
@@ -41,4 +42,8 @@ impl CanvasState for FormState {
             .get_mut(self.current_field)
             .expect("Invalid current_field index")
     }
+
+    fn fields(&self) -> Vec<&str> {
+        self.fields.iter().map(|s| s.as_str()).collect()
+    }
 }

client/src/state/pages/auth.rs

@@ -9,6 +9,9 @@ pub struct AuthState {
     pub error_message: Option<String>,
     pub current_field: usize,
     pub current_cursor_pos: usize,
+    pub auth_token: Option<String>,
+    pub user_id: Option<String>,
+    pub role: Option<String>,
 }
 
 impl AuthState {
@@ -20,6 +23,9 @@ impl AuthState {
             error_message: None,
             current_field: 0,
             current_cursor_pos: 0,
+            auth_token: None,
+            user_id: None,
+            role: None,
         }
     }
 }
@@ -57,4 +63,8 @@ impl CanvasState for AuthState {
             _ => panic!("Invalid current_field index in AuthState"),
         }
     }
+
+    fn fields(&self) -> Vec<&str> {
+        vec!["Username/Email", "Password"]
+    }
 }

client/src/state/state.rs

@@ -5,6 +5,14 @@ use common::proto::multieko2::table_definition::ProfileTreeResponse;
 use crate::components::IntroState;
 use crate::modes::handlers::mode_manager::AppMode;
 
+#[derive(Default)]
+pub struct DialogState {
+    pub show_dialog: bool,
+    pub dialog_title: String,
+    pub dialog_message: String,
+    pub dialog_button_active: bool,
+}
+
 pub struct UiState {
     pub show_sidebar: bool,
     pub is_saved: bool,
@@ -13,6 +21,7 @@ pub struct UiState {
     pub show_form: bool,
     pub show_login: bool,
     pub intro_state: IntroState,
+    pub dialog: DialogState,  // Add dialog state here
 }
 
 pub struct GeneralState {
@@ -66,6 +75,24 @@ impl AppState {
     pub fn update_mode(&mut self, mode: AppMode) {
         self.current_mode = mode;
     }
+
+    // Add dialog helper methods
+    pub fn show_dialog(&mut self, title: &str, message: &str) {
+        self.ui.dialog.show_dialog = true;
+        self.ui.dialog.dialog_title = title.to_string();
+        self.ui.dialog.dialog_message = message.to_string();
+        self.ui.dialog.dialog_button_active = true;
+    }
+
+    pub fn hide_dialog(&mut self) {
+        self.ui.dialog.show_dialog = false;
+        self.ui.dialog.dialog_title.clear();
+        self.ui.dialog.dialog_message.clear();
+    }
+
+    pub fn set_dialog_button_active(&mut self, active: bool) {
+        self.ui.dialog.dialog_button_active = active;
+    }
 }
 
 impl Default for UiState {
@@ -78,6 +105,7 @@ impl Default for UiState {
             show_form: false,
             show_login: false,
             intro_state: IntroState::new(),
+            dialog: DialogState::default(),
         }
     }
 }

client/src/tui/functions/form.rs

@@ -1,6 +1,6 @@
 // src/tui/functions/form.rs
 use crate::state::pages::form::FormState;
-use crate::tui::terminal::GrpcClient;
+use crate::services::grpc_client::GrpcClient;
 use common::proto::multieko2::adresar::AdresarResponse;
 
 pub async fn handle_action(

client/src/tui/functions/login.rs

@@ -10,49 +10,55 @@ pub async fn handle_action(
     match action {
         "move_up" => {
             if auth_state.return_selected {
-                // Coming from return button to fields
+                // From Return button to last field (password)
                 auth_state.return_selected = false;
-                auth_state.current_field = 1; // Focus on password field
+                auth_state.current_field = 1;
             } else if auth_state.current_field == 1 {
-                // Moving from password to username/email
+                // Password -> Username
                 auth_state.current_field = 0;
             } else if auth_state.current_field == 0 {
-                // Wrap around to buttons
-                auth_state.return_selected = false; // Select Login button
+                // Username -> Password (wrap around fields only)
+                auth_state.current_field = 1;
+            } else if auth_state.current_field == 2 {
+                // From Login button to Password field
+                auth_state.current_field = 1;
             }
 
-            // Update cursor position when in a field
-            if !auth_state.return_selected {
+            // Update cursor position only when in a field
+            if auth_state.current_field < 2 {
                 let current_input = auth_state.get_current_input();
                 let max_cursor_pos = current_input.len();
                 auth_state.current_cursor_pos = (*ideal_cursor_column).min(max_cursor_pos);
             }
 
             Ok(format!("Navigation 'up' from functions/login"))
-        },
+        }
         "move_down" => {
             if auth_state.return_selected {
-                // Coming from return button to fields
+                // From Return button to first field (username)
                 auth_state.return_selected = false;
-                auth_state.current_field = 0; // Focus on username field
+                auth_state.current_field = 0;
             } else if auth_state.current_field == 0 {
-                // Moving from username/email to password
+                // Username -> Password
                 auth_state.current_field = 1;
             } else if auth_state.current_field == 1 {
-                // Moving from password to buttons
-                auth_state.return_selected = false; // Select Login button
+                // Password -> Login button
+                auth_state.current_field = 2;
+                auth_state.return_selected = false;
+            } else if auth_state.current_field == 2 {
+                // Login button -> Return button
+                auth_state.return_selected = true;
             }
 
-            // Update cursor position when in a field
-            if !auth_state.return_selected {
+            // Update cursor position only when in a field
+            if auth_state.current_field < 2 {
                 let current_input = auth_state.get_current_input();
                 let max_cursor_pos = current_input.len();
                 auth_state.current_cursor_pos = (*ideal_cursor_column).min(max_cursor_pos);
             }
 
             Ok(format!("Navigation 'down' from functions/login"))
-        },
+        }
         _ => Err("Unknown login action".into())
     }
 }
-

client/src/tui/terminal.rs

@@ -1,9 +1,7 @@
 // src/tui/terminal.rs
 
 pub mod core;
-pub mod grpc_client;
 pub mod event_reader;
 
 pub use core::TerminalCore;
-pub use grpc_client::GrpcClient;
 pub use event_reader::EventReader;

client/src/ui/handlers/render.rs

@@ -47,7 +47,14 @@ pub fn render_ui(
         // Use app_state's intro_state directly
         app_state.ui.intro_state.render(f, main_content_area, theme);
     }else if app_state.ui.show_login {
-        render_login(f, main_content_area, theme, auth_state);
+        render_login(
+            f, 
+            main_content_area, 
+            theme, 
+            auth_state,
+            app_state,  // Add AppState reference here
+            auth_state.current_field < 2
+        );
     } else if app_state.ui.show_admin {
         // Create temporary AdminPanelState for rendering
         let mut admin_state = AdminPanelState::new(

client/src/ui/handlers/ui.rs

@@ -1,7 +1,7 @@
 // src/ui/handlers/ui.rs
 
 use crate::tui::terminal::TerminalCore;
-use crate::tui::terminal::GrpcClient;
+use crate::services::grpc_client::GrpcClient;
 use crate::tui::controls::CommandHandler;
 use crate::tui::terminal::EventReader;
 use crate::config::colors::themes::Theme;