fixed highlight logic

client/config.toml

@@ -49,9 +49,18 @@ move_line_start = ["0"]
 move_line_end = ["$"]
 move_first_line = ["gg"]
 move_last_line = ["x"]
+enter_highlight_mode = ["v"]
+enter_highlight_mode_linewise = ["ctrl+v"]
+
+[keybindings.highlight]
+exit_highlight_mode = ["esc"]
+enter_highlight_mode_linewise = ["ctrl+v"]
 
 [keybindings.edit]
-exit_edit_mode = ["esc","ctrl+e"]
+# BIG CHANGES NOW EXIT HANDLES EITHER IF THOSE
+# exit_edit_mode = ["esc","ctrl+e"]
+# exit_suggestion_mode = ["esc"]
+exit = ["esc", "ctrl+e"]
 delete_char_forward = ["delete"]
 delete_char_backward = ["backspace"]
 next_field = ["enter"]
@@ -61,7 +70,6 @@ move_right = ["right"]
 suggestion_down = ["ctrl+n", "tab"]
 suggestion_up = ["ctrl+p", "shift+tab"]
 select_suggestion = ["enter"]
-exit_suggestion_mode = ["esc"]
 
 [keybindings.command]
 exit_command_mode = ["ctrl+g", "esc"]

client/src/components/auth/login.rs

@@ -12,6 +12,7 @@ use ratatui::{
     widgets::{Block, BorderType, Borders, Paragraph},
     Frame,
 };
+use crate::state::app::highlight::HighlightState;
 
 pub fn render_login(
     f: &mut Frame,
@@ -20,6 +21,7 @@ pub fn render_login(
     login_state: &LoginState,
     app_state: &AppState,
     is_edit_mode: bool,
+    highlight_state: &HighlightState,
 ) {
     // Main container
     let block = Block::default()
@@ -56,6 +58,7 @@ pub fn render_login(
         &[&login_state.username, &login_state.password],
         theme,
         is_edit_mode,
+        highlight_state,
     );
 
     // --- ERROR MESSAGE ---

client/src/components/auth/register.rs

@@ -14,6 +14,7 @@ use ratatui::{
     widgets::{Block, BorderType, Borders, Paragraph},
     Frame,
 };
+use crate::state::app::highlight::HighlightState;
 
 pub fn render_register(
     f: &mut Frame,
@@ -22,6 +23,7 @@ pub fn render_register(
     state: &RegisterState, // Use RegisterState
     app_state: &AppState,
     is_edit_mode: bool,
+    highlight_state: &HighlightState,
 ) {
     let block = Block::default()
         .borders(Borders::ALL)
@@ -64,6 +66,7 @@ pub fn render_register(
         &state.inputs().iter().map(|s| *s).collect::<Vec<&String>>(), // Pass inputs directly
         theme,
         is_edit_mode,
+        highlight_state,
     );
 
     // --- HELP TEXT ---

client/src/components/form/form.rs

@@ -7,6 +7,7 @@ use ratatui::{
 };
 use crate::config::colors::themes::Theme;
 use crate::state::pages::canvas_state::CanvasState;
+use crate::state::app::highlight::HighlightState;
 use crate::components::handlers::canvas::render_canvas;
 
 pub fn render_form(
@@ -18,6 +19,7 @@ pub fn render_form(
     inputs: &[&String],
     theme: &Theme,
     is_edit_mode: bool,
+    highlight_state: &HighlightState,
     total_count: u64,
     current_position: u64,
 ) {
@@ -62,5 +64,6 @@ pub fn render_form(
         inputs,
         theme,
         is_edit_mode,
+        highlight_state,
     );
 }

client/src/components/handlers/canvas.rs

@@ -2,31 +2,33 @@
 use ratatui::{
     widgets::{Paragraph, Block, Borders},
     layout::{Layout, Constraint, Direction, Rect},
-    style::Style,
+    style::{Style, Modifier},
     text::{Line, Span},
     Frame,
     prelude::Alignment,
 };
 use crate::config::colors::themes::Theme;
 use crate::state::pages::canvas_state::CanvasState;
+use crate::state::app::highlight::HighlightState; // Ensure correct import path
+use std::cmp::{min, max};
 
 pub fn render_canvas(
     f: &mut Frame,
     area: Rect,
     form_state: &impl CanvasState,
     fields: &[&str],
-    current_field: &usize,
+    current_field_idx: &usize,
     inputs: &[&String],
     theme: &Theme,
     is_edit_mode: bool,
+    highlight_state: &HighlightState, // Using the enum state
 ) -> Option<Rect> {
-    // Split area into columns
+    // ... (setup code remains the same) ...
     let columns = Layout::default()
         .direction(Direction::Horizontal)
         .constraints([Constraint::Percentage(30), Constraint::Percentage(70)])
         .split(area);
 
-    // Input container styling
     let border_style = if form_state.has_unsaved_changes() {
         Style::default().fg(theme.warning)
     } else if is_edit_mode {
@@ -39,7 +41,6 @@ pub fn render_canvas(
         .border_style(border_style)
         .style(Style::default().bg(theme.bg));
 
-    // Input block dimensions
     let input_block = Rect {
         x: columns[1].x,
         y: columns[1].y,
@@ -49,7 +50,6 @@ pub fn render_canvas(
 
     f.render_widget(&input_container, input_block);
 
-    // Input rows layout
     let input_area = input_container.inner(input_block);
     let input_rows = Layout::default()
         .direction(Direction::Vertical)
@@ -72,17 +72,113 @@ pub fn render_canvas(
         });
     }
 
+
     // Render inputs and cursor
     for (i, input) in inputs.iter().enumerate() {
-        let is_active = i == *current_field;
-        let input_display = Paragraph::new(input.as_str())
-            .alignment(Alignment::Left)
-            .style(if is_active {
-                Style::default().fg(theme.highlight)
-            } else {
-                Style::default().fg(theme.fg)
-            });
+        let is_active = i == *current_field_idx;
+        let current_cursor_pos = form_state.current_cursor_pos();
+        let text = input.as_str();
+        let text_len = text.chars().count();
 
+        let line: Line;
+
+        // --- Use match on the highlight_state enum ---
+        match highlight_state {
+            HighlightState::Off => {
+                // Not in highlight mode, render normally
+                line = Line::from(Span::styled(
+                    text,
+                    if is_active { Style::default().fg(theme.highlight) } else { Style::default().fg(theme.fg) }
+                ));
+            }
+            HighlightState::Characterwise { anchor } => {
+                // --- Character-wise Highlight Logic ---
+                let (anchor_field, anchor_char) = *anchor;
+                let start_field = min(anchor_field, *current_field_idx);
+                let end_field = max(anchor_field, *current_field_idx);
+
+                // Use start_char and end_char consistently
+                let (start_char, end_char) = if anchor_field == *current_field_idx {
+                    (min(anchor_char, current_cursor_pos), max(anchor_char, current_cursor_pos))
+                } else if anchor_field < *current_field_idx {
+                    (anchor_char, current_cursor_pos)
+                } else {
+                    (current_cursor_pos, anchor_char)
+                };
+
+                let highlight_style = Style::default().fg(theme.highlight).bg(theme.highlight_bg).add_modifier(Modifier::BOLD);
+                let normal_style_in_highlight = Style::default().fg(theme.highlight);
+                let normal_style_outside = Style::default().fg(theme.fg);
+
+                if i >= start_field && i <= end_field {
+                    // This line is within the character-wise highlight range
+                    if start_field == end_field { // Case 1: Single Line Highlight
+                        // Use start_char and end_char here
+                        let clamped_start = start_char.min(text_len);
+                        let clamped_end = end_char.min(text_len); // Use text_len for slicing logic
+
+                        let before: String = text.chars().take(clamped_start).collect();
+                        let highlighted: String = text.chars().skip(clamped_start).take(clamped_end.saturating_sub(clamped_start) + 1).collect();
+                        // Define 'after' here
+                        let after: String = text.chars().skip(clamped_end + 1).collect();
+
+                        line = Line::from(vec![
+                            Span::styled(before, normal_style_in_highlight),
+                            Span::styled(highlighted, highlight_style),
+                            Span::styled(after, normal_style_in_highlight), // Use defined 'after'
+                        ]);
+                    } else if i == start_field { // Case 2: Multi-Line Highlight - Start Line
+                        // Use start_char here
+                        let safe_start = start_char.min(text_len);
+                        let before: String = text.chars().take(safe_start).collect();
+                        let highlighted: String = text.chars().skip(safe_start).collect();
+                        line = Line::from(vec![
+                            Span::styled(before, normal_style_in_highlight),
+                            Span::styled(highlighted, highlight_style),
+                        ]);
+                    } else if i == end_field { // Case 3: Multi-Line Highlight - End Line (Corrected index)
+                        // Use end_char here
+                        let safe_end_inclusive = if text_len > 0 { end_char.min(text_len - 1) } else { 0 };
+                        let highlighted: String = text.chars().take(safe_end_inclusive + 1).collect();
+                        let after: String = text.chars().skip(safe_end_inclusive + 1).collect();
+                        line = Line::from(vec![
+                            Span::styled(highlighted, highlight_style),
+                            Span::styled(after, normal_style_in_highlight),
+                        ]);
+                    } else { // Case 4: Multi-Line Highlight - Middle Line (Corrected index)
+                        line = Line::from(Span::styled(text, highlight_style)); // Highlight whole line
+                    }
+                } else { // Case 5: Line Outside Character-wise Highlight Range
+                    line = Line::from(Span::styled(
+                        text,
+                        // Use normal styling (active or inactive)
+                        if is_active { normal_style_in_highlight } else { normal_style_outside }
+                    ));
+                }
+            }
+            HighlightState::Linewise { anchor_line } => {
+                // --- Linewise Highlight Logic ---
+                let start_field = min(*anchor_line, *current_field_idx);
+                let end_field = max(*anchor_line, *current_field_idx);
+                let highlight_style = Style::default().fg(theme.highlight).bg(theme.highlight_bg).add_modifier(Modifier::BOLD);
+                let normal_style_in_highlight = Style::default().fg(theme.highlight);
+                let normal_style_outside = Style::default().fg(theme.fg);
+
+                if i >= start_field && i <= end_field {
+                    // Highlight the entire line
+                    line = Line::from(Span::styled(text, highlight_style));
+                } else {
+                    // Line outside linewise highlight range
+                    line = Line::from(Span::styled(
+                        text,
+                        // Use normal styling (active or inactive)
+                        if is_active { normal_style_in_highlight } else { normal_style_outside }
+                    ));
+                }
+            }
+        } // End match highlight_state
+
+        let input_display = Paragraph::new(line).alignment(Alignment::Left);
         f.render_widget(input_display, input_rows[i]);
 
         if is_active {
@@ -95,3 +191,4 @@ pub fn render_canvas(
 
     active_field_input_rect
 }
+

client/src/config/binds/config.rs

@@ -32,6 +32,8 @@ pub struct ModeKeybindings {
     #[serde(default)]
     pub edit: HashMap<String, Vec<String>>,
     #[serde(default)]
+    pub highlight: HashMap<String, Vec<String>>,
+    #[serde(default)]
     pub command: HashMap<String, Vec<String>>,
     #[serde(default)]
     pub common: HashMap<String, Vec<String>>,
@@ -75,6 +77,14 @@ impl Config {
             .or_else(|| self.get_action_for_key_in_mode(&self.keybindings.global, key, modifiers))
     }
 
+    /// Gets an action for a key in Highlight mode, also checking common/global keybindings.
+    pub fn get_highlight_action_for_key(&self, key: KeyCode, modifiers: KeyModifiers) -> Option<&str> {
+        self.get_action_for_key_in_mode(&self.keybindings.highlight, key, modifiers)
+            .or_else(|| self.get_action_for_key_in_mode(&self.keybindings.common, key, modifiers))
+            .or_else(|| self.get_action_for_key_in_mode(&self.keybindings.read_only, key, modifiers))
+            .or_else(|| self.get_action_for_key_in_mode(&self.keybindings.global, key, modifiers))
+    }
+
     /// Gets an action for a key in Command mode, also checking common keybindings.
     pub fn get_command_action_for_key(&self, key: KeyCode, modifiers: KeyModifiers) -> Option<&str> {
         self.get_action_for_key_in_mode(&self.keybindings.command, key, modifiers)

client/src/config/colors/themes.rs

@@ -10,6 +10,7 @@ pub struct Theme {
     pub highlight: Color,
     pub warning: Color,
     pub border: Color,
+    pub highlight_bg: Color,
 }
 
 impl Theme {
@@ -31,6 +32,7 @@ impl Theme {
             highlight: Color::Rgb(152, 251, 152), // Pastel green
             warning: Color::Rgb(255, 182, 193), // Pastel pink
             border: Color::Rgb(220, 220, 220), // Light gray border
+            highlight_bg: Color::Rgb(70, 70, 70), // Darker grey for highlight background
         }
     }
 
@@ -44,6 +46,7 @@ impl Theme {
             highlight: Color::Rgb(50, 205, 50), // Bright green
             warning: Color::Rgb(255, 99, 71), // Bright red
             border: Color::Rgb(100, 100, 100), // Medium gray border
+            highlight_bg: Color::Rgb(180, 180, 180), // Lighter grey for highlight background
         }
     }
 
@@ -57,6 +60,7 @@ impl Theme {
             highlight: Color::Rgb(0, 128, 0), // Green
             warning: Color::Rgb(255, 0, 0), // Red
             border: Color::Rgb(0, 0, 0),   // Black border
+            highlight_bg: Color::Rgb(180, 180, 180), // Lighter grey for highlight background
         }
     }
 }

client/src/modes/canvas/edit.rs

@@ -1,14 +1,19 @@
 // src/modes/canvas/edit.rs
-
 use crate::config::binds::config::Config;
 use crate::services::grpc_client::GrpcClient;
-use crate::state::pages::{auth::{LoginState, RegisterState}};
-use crate::state::pages::canvas_state::CanvasState;
+use crate::state::pages::{auth::{LoginState, RegisterState}, canvas_state::CanvasState};
 use crate::state::pages::form::FormState;
-use crate::functions::modes::edit::{auth_e, form_e};
 use crate::modes::handlers::event::EventOutcome;
+use crate::functions::modes::edit::{auth_e, form_e};
 use crate::state::app::state::AppState;
 use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
+// Removed duplicate/unused imports
+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub enum EditEventOutcome {
+    Message(String), // Return a message, stay in Edit mode
+    ExitEditMode,    // Signal to exit Edit mode
+}
 
 pub async fn handle_edit_event(
     key: KeyEvent,
@@ -17,12 +22,12 @@ pub async fn handle_edit_event(
     login_state: &mut LoginState,
     register_state: &mut RegisterState,
     ideal_cursor_column: &mut usize,
-    command_message: &mut String,
+    // command_message: &mut String, // Removed as messages are returned
     current_position: &mut u64,
     total_count: u64,
     grpc_client: &mut GrpcClient,
     app_state: &AppState,
-) -> Result<String, Box<dyn std::error::Error>> {
+) -> Result<EditEventOutcome, Box<dyn std::error::Error>> {
 
     // Global command mode check
     if let Some("enter_command_mode") = config.get_action_for_key_in_mode(
@@ -30,8 +35,7 @@ pub async fn handle_edit_event(
         key.code,
         key.modifiers
     ) {
-        *command_message = "Switching to Command Mode...".to_string();
-        return Ok(command_message.clone());
+        return Ok(EditEventOutcome::Message("Switching to Command Mode...".to_string()));
     }
 
     // Common actions (save/revert)
@@ -41,14 +45,15 @@ pub async fn handle_edit_event(
         key.modifiers
     ) {
         if matches!(action, "save" | "revert") {
-            let message = if app_state.ui.show_login {
+            // Ensure all branches result in Result<String, Error> before the final Ok(...) wrap
+            let message_string: String = if app_state.ui.show_login {
                 auth_e::execute_common_action(
                     action,
                     login_state,
                     grpc_client,
                     current_position,
                     total_count
-                ).await
+                ).await? // Results in String on success
             } else if app_state.ui.show_register {
                 auth_e::execute_common_action(
                     action,
@@ -56,46 +61,66 @@ pub async fn handle_edit_event(
                     grpc_client,
                     current_position,
                     total_count
-                ).await
+                ).await? // Results in String on success
             } else {
-                form_e::execute_common_action(
+                let outcome = form_e::execute_common_action(
                     action,
-                    form_state,  // Concrete FormState
+                    form_state,
                     grpc_client,
                     current_position,
                     total_count
-                ).await
-                .map(|outcome| match outcome {
+                ).await?; // This returns EventOutcome on success
+
+                // Extract the message string from the EventOutcome
+                match outcome {
                     EventOutcome::Ok(msg) => msg,
-                    EventOutcome::Exit(msg) => format!("Exit requested: {}", msg),
-                    EventOutcome::DataSaved(save_outcome, msg) => format!("Data saved ({:?}): {}", save_outcome, msg),
-                    EventOutcome::ButtonSelected { context, index } => {
-                        "Unexpected action in edit mode".to_string()
-                    }
-                })
-            }?;
-            return Ok(message);
+                    EventOutcome::DataSaved(_, msg) => msg,
+                    _ => format!("Unexpected outcome from common action: {:?}", outcome),
+                }
+            };
+            // Wrap the resulting String message
+            return Ok(EditEventOutcome::Message(message_string));
         }
     }
 
     // Edit-specific actions
     if let Some(action) = config.get_edit_action_for_key(key.code, key.modifiers) {
-        // --- Special Handling for Tab/Shift+Tab in Role Field ---
+        if action == "exit" {
+            if app_state.ui.show_register && register_state.in_suggestion_mode {
+                // Call the action, get Result<String, Error>
+                let msg = auth_e::execute_edit_action(
+                    "exit_suggestion_mode",
+                    key,
+                    register_state,
+                    ideal_cursor_column,
+                    grpc_client,
+                    current_position,
+                    total_count,
+                ).await?; // Results in String on success
+                // Wrap the String message
+                return Ok(EditEventOutcome::Message(msg));
+            } else {
+                // Signal exit
+                return Ok(EditEventOutcome::ExitEditMode);
+            }
+        }
+
+        // Special handling for role field suggestions
         if app_state.ui.show_register && register_state.current_field() == 4 {
             if !register_state.in_suggestion_mode && key.code == KeyCode::Tab && key.modifiers == KeyModifiers::NONE {
                 register_state.update_role_suggestions();
                 if !register_state.role_suggestions.is_empty() {
                     register_state.in_suggestion_mode = true;
-                    register_state.selected_suggestion_index = Some(0); // Select first suggestion
-                    return Ok("Suggestions shown".to_string());
-                } else {
-                    return Ok("No suggestions available".to_string());
+                    register_state.selected_suggestion_index = Some(0);
+                    return Ok(EditEventOutcome::Message("Suggestions shown".to_string()));
+                } else { // Added else here for clarity
+                    return Ok(EditEventOutcome::Message("No suggestions available".to_string()));
                 }
             }
         }
-        // --- End Special Handling ---
 
-        return if app_state.ui.show_login {
+        // Execute other edit actions
+        let msg = if app_state.ui.show_login {
             auth_e::execute_edit_action(
                 action,
                 key,
@@ -104,7 +129,7 @@ pub async fn handle_edit_event(
                 grpc_client,
                 current_position,
                 total_count
-            ).await
+            ).await? // Results in String
         } else if app_state.ui.show_register {
             auth_e::execute_edit_action(
                 action,
@@ -114,7 +139,7 @@ pub async fn handle_edit_event(
                 grpc_client,
                 current_position,
                 total_count
-            ).await
+            ).await? // Results in String
         } else {
             form_e::execute_edit_action(
                 action,
@@ -124,22 +149,22 @@ pub async fn handle_edit_event(
                 grpc_client,
                 current_position,
                 total_count
-            ).await
+            ).await? // Results in String
         };
+        // Wrap the resulting String message
+        return Ok(EditEventOutcome::Message(msg));
     }
 
     // Character insertion
     if let KeyCode::Char(_) = key.code {
-        // If in suggestion mode, exit it before inserting char
         if app_state.ui.show_register && register_state.in_suggestion_mode {
             register_state.in_suggestion_mode = false;
             register_state.show_role_suggestions = false;
             register_state.selected_suggestion_index = None;
         }
-        let is_role_field = app_state.ui.show_register && register_state.current_field() == 4;
-        // --- End Autocomplete Trigger ---
-        
-        return if app_state.ui.show_login {
+
+        // Execute insert_char action
+        let msg = if app_state.ui.show_login {
             auth_e::execute_edit_action(
                 "insert_char",
                 key,
@@ -148,7 +173,7 @@ pub async fn handle_edit_event(
                 grpc_client,
                 current_position,
                 total_count
-            ).await
+            ).await? // Results in String
         } else if app_state.ui.show_register {
             auth_e::execute_edit_action(
                 "insert_char",
@@ -158,7 +183,7 @@ pub async fn handle_edit_event(
                 grpc_client,
                 current_position,
                 total_count
-            ).await
+            ).await? // Results in String
         } else {
             form_e::execute_edit_action(
                 "insert_char",
@@ -168,23 +193,23 @@ pub async fn handle_edit_event(
                 grpc_client,
                 current_position,
                 total_count
-            ).await
+            ).await? // Results in String
         };
+        // Wrap the resulting String message
+        return Ok(EditEventOutcome::Message(msg));
     }
 
-    // Handle Backspace/Delete for Autocomplete Trigger
+    // Handle Backspace/Delete
     if matches!(key.code, KeyCode::Backspace | KeyCode::Delete) {
-        // If in suggestion mode, exit it before deleting char
         if app_state.ui.show_register && register_state.in_suggestion_mode {
             register_state.in_suggestion_mode = false;
             register_state.show_role_suggestions = false;
             register_state.selected_suggestion_index = None;
         }
-        let is_role_field = app_state.ui.show_register && register_state.current_field() == 4;
-        let action_str = if key.code == KeyCode::Backspace { "backspace" } else { "delete_char" };
 
-        // Execute the action first
-        let result = if app_state.ui.show_register {
+        let action_str = if key.code == KeyCode::Backspace { "backspace" } else { "delete_char" };
+        // Ensure both branches result in a String *before* wrapping
+        let result_msg: String = if app_state.ui.show_register {
              auth_e::execute_edit_action(
                 action_str,
                 key,
@@ -193,14 +218,17 @@ pub async fn handle_edit_event(
                 grpc_client,
                 current_position,
                 total_count
-            ).await
+            ).await? // Results in String
         } else {
-            // Handle for login/form if needed, assuming auth_e covers RegisterState
-             Ok("Action not applicable here".to_string()) // Placeholder
-        }?;
+             // Return String directly, not Ok(String)
+             "Action not applicable here".to_string()
+        }; // Semicolon here ends the if/else expression
 
-        return Ok(result);
+        // Wrap the resulting String message
+        return Ok(EditEventOutcome::Message(result_msg));
     }
 
-    Ok(command_message.clone())
+    // Default return if no other handler matched
+    Ok(EditEventOutcome::Message("".to_string()))
 }
+

client/src/modes/handlers/event.rs

@@ -20,6 +20,7 @@ use crate::tui::{
 };
 use crate::state::{
     app::{
+        highlight::HighlightState,
         state::AppState,
         buffer::{AppView, BufferState},
     },
@@ -35,6 +36,7 @@ use crate::modes::{
     common::{command_mode, commands::CommandHandler},
     handlers::mode_manager::{ModeManager, AppMode},
     canvas::{edit, read_only, common_mode},
+    highlight::highlight,
     general::{navigation, dialog},
 };
 use crate::config::binds::key_sequences::KeySequenceTracker;
@@ -52,6 +54,7 @@ pub struct EventHandler {
     pub command_input: String,
     pub command_message: String,
     pub is_edit_mode: bool,
+    pub highlight_state: HighlightState,
     pub edit_mode_cooldown: bool,
     pub ideal_cursor_column: usize,
     pub key_sequence_tracker: KeySequenceTracker,
@@ -65,6 +68,7 @@ impl EventHandler {
             command_input: String::new(),
             command_message: String::new(),
             is_edit_mode: false,
+            highlight_state: HighlightState::Off,
             edit_mode_cooldown: false,
             ideal_cursor_column: 0,
             key_sequence_tracker: KeySequenceTracker::new(800),
@@ -93,7 +97,6 @@ impl EventHandler {
         let current_mode = ModeManager::derive_mode(app_state, self);
         app_state.update_mode(current_mode);
 
-        // Determine the current view, including dynamic names
         let current_view = {
             let ui = &app_state.ui;
             if ui.show_intro { AppView::Intro }
@@ -108,7 +111,6 @@ impl EventHandler {
         };
         buffer_state.update_history(current_view);
 
-        // --- DIALOG MODALITY ---
         if app_state.ui.dialog.dialog_show {
             if let Some(dialog_result) = dialog::handle_dialog_event(
                 &event, config, app_state, auth_state, login_state, register_state, buffer_state
@@ -117,7 +119,6 @@ impl EventHandler {
             }
             return Ok(EventOutcome::Ok(String::new()));
         }
-        // --- END DIALOG MODALITY CHECK ---
 
         if let Event::Key(key) = event {
             let key_code = key.code;
@@ -135,10 +136,10 @@ impl EventHandler {
                 );
                 return Ok(EventOutcome::Ok(message));
             }
-            // --- Buffer Switching (Check Global) ---
+
             if !matches!(current_mode, AppMode::Edit | AppMode::Command) {
                 if let Some(action) = config.get_action_for_key_in_mode(
-                    &config.keybindings.global, key_code, modifiers // Check global bindings
+                    &config.keybindings.global, key_code, modifiers
                 ) {
                     match action {
                         "next_buffer" => {
@@ -151,11 +152,10 @@ impl EventHandler {
                                 return Ok(EventOutcome::Ok("Switched to previous buffer".to_string()));
                             }
                         }
-                        _ => {} // Other global actions could be handled here if needed
+                        _ => {}
                     }
                 }
             }
-            // --- End Global UI Toggles ---
 
             match current_mode {
                 AppMode::General => {
@@ -174,7 +174,7 @@ impl EventHandler {
                     ).await;
                     match nav_outcome {
                         Ok(EventOutcome::ButtonSelected { context, index }) => {
-                            let mut message = String::from("Selected"); // Default message
+                            let mut message = String::from("Selected");
                             match context {
                                 UiContext::Intro => {
                                     intro::handle_intro_selection(app_state, buffer_state, index);
@@ -202,31 +202,57 @@ impl EventHandler {
                                 }
                                 UiContext::Admin => {
                                     admin::handle_admin_selection(app_state, admin_state);
-
                                     message = format!("Admin Option {} selected", index);
                                 }
                                 UiContext::Dialog => {
                                     message = "Internal error: Unexpected dialog state".to_string();
                                 }
                             }
-                            return Ok(EventOutcome::Ok(message)); // Return Ok with message
+                            return Ok(EventOutcome::Ok(message));
                         }
-                        other => return other, // Pass through Ok, Err, DataSaved directly
+                        other => return other,
                     }
                 },
 
                 AppMode::ReadOnly => {
-                    if config.is_enter_edit_mode_before(key_code, modifiers) &&
-                       ModeManager::can_enter_edit_mode(current_mode) {
+                    // Check for Linewise highlight first
+                    if config.get_read_only_action_for_key(key_code, modifiers) == Some("enter_highlight_mode_linewise")
+                        && ModeManager::can_enter_highlight_mode(current_mode)
+                    {
+                        let current_field_index = if app_state.ui.show_login { login_state.current_field() }
+                                              else if app_state.ui.show_register { register_state.current_field() }
+                                              else { form_state.current_field() };
+                        self.highlight_state = HighlightState::Linewise { anchor_line: current_field_index };
+                        self.command_message = "-- LINE HIGHLIGHT --".to_string();
+                        return Ok(EventOutcome::Ok(self.command_message.clone()));
+                    }
+                    // Check for Character-wise highlight
+                    else if config.get_read_only_action_for_key(key_code, modifiers) == Some("enter_highlight_mode")
+                        && ModeManager::can_enter_highlight_mode(current_mode)
+                    {
+                        let current_field_index = if app_state.ui.show_login { login_state.current_field() }
+                                              else if app_state.ui.show_register { register_state.current_field() }
+                                              else { form_state.current_field() };
+                        let current_cursor_pos = if app_state.ui.show_login { login_state.current_cursor_pos() }
+                                             else if app_state.ui.show_register { register_state.current_cursor_pos() }
+                                             else { form_state.current_cursor_pos() };
+                        let anchor = (current_field_index, current_cursor_pos);
+                        self.highlight_state = HighlightState::Characterwise { anchor };
+                        self.command_message = "-- HIGHLIGHT --".to_string();
+                        return Ok(EventOutcome::Ok(self.command_message.clone()));
+                    }
+                    // Check for entering edit mode (before cursor)
+                    else if config.get_read_only_action_for_key(key_code, modifiers) == Some("enter_edit_mode_before")
+                        && ModeManager::can_enter_edit_mode(current_mode) {
                         self.is_edit_mode = true;
                         self.edit_mode_cooldown = true;
                         self.command_message = "Edit mode".to_string();
                         terminal.set_cursor_style(SetCursorStyle::BlinkingBar)?;
                         return Ok(EventOutcome::Ok(self.command_message.clone()));
                     }
-
-                    if config.is_enter_edit_mode_after(key_code, modifiers) &&
-                       ModeManager::can_enter_edit_mode(current_mode) {
+                    // Check for entering edit mode (after cursor)
+                    else if config.get_read_only_action_for_key(key_code, modifiers) == Some("enter_edit_mode_after")
+                        && ModeManager::can_enter_edit_mode(current_mode) {
                         let current_input = if app_state.ui.show_login || app_state.ui.show_register{
                             login_state.get_current_input()
                         } else {
@@ -253,21 +279,17 @@ impl EventHandler {
                         terminal.set_cursor_style(SetCursorStyle::BlinkingBar)?;
                         return Ok(EventOutcome::Ok(self.command_message.clone()));
                     }
-
-                    if let Some(action) = config.get_read_only_action_for_key(key_code, modifiers) {
-                        if action == "enter_command_mode" && ModeManager::can_enter_command_mode(current_mode) {
+                    // Check for entering command mode
+                    else if config.get_read_only_action_for_key(key_code, modifiers) == Some("enter_command_mode")
+                         && ModeManager::can_enter_command_mode(current_mode) {
                             self.command_mode = true;
                             self.command_input.clear();
                             self.command_message.clear();
                             return Ok(EventOutcome::Ok(String::new()));
-                        }
                     }
 
-                    if let Some(action) = config.get_action_for_key_in_mode(
-                        &config.keybindings.common,
-                        key_code,
-                        modifiers
-                    ) {
+                    // Check for common actions (save, quit, etc.) only if no mode change happened
+                    if let Some(action) = config.get_common_action(key_code, modifiers) {
                         match action {
                             "save" | "force_quit" | "save_and_quit" | "revert" => {
                                 return common_mode::handle_core_action(
@@ -288,6 +310,7 @@ impl EventHandler {
                         }
                     }
 
+                    // If no mode change or specific common action handled, delegate to read_only handler
                     let (_should_exit, message) = read_only::handle_read_only_event(
                         app_state,
                         key,
@@ -303,59 +326,50 @@ impl EventHandler {
                         &mut self.edit_mode_cooldown,
                         &mut self.ideal_cursor_column,
                     ).await?;
+                    // Note: handle_read_only_event should ignore mode entry keys internally now
                     return Ok(EventOutcome::Ok(message));
-                },
+                }, // End AppMode::ReadOnly
+
+                AppMode::Highlight => {
+                     // --- Handle Highlight Mode Specific Keys ---
+                     // 1. Check for Exit first
+                     if config.get_highlight_action_for_key(key_code, modifiers) == Some("exit_highlight_mode") {
+                         self.highlight_state = HighlightState::Off;
+                         self.command_message = "Exited highlight mode".to_string();
+                         terminal.set_cursor_style(SetCursorStyle::SteadyBlock)?;
+                         return Ok(EventOutcome::Ok(self.command_message.clone()));
+                     }
+                     // 2. Check for Switch to Linewise
+                     else if config.get_highlight_action_for_key(key_code, modifiers) == Some("enter_highlight_mode_linewise") {
+                         // Only switch if currently characterwise
+                         if let HighlightState::Characterwise { anchor } = self.highlight_state {
+                             self.highlight_state = HighlightState::Linewise { anchor_line: anchor.0 };
+                             self.command_message = "-- LINE HIGHLIGHT --".to_string();
+                             return Ok(EventOutcome::Ok(self.command_message.clone()));
+                         }
+                        return Ok(EventOutcome::Ok("".to_string()));
+                     }
+
+                    let (_should_exit, message) = read_only::handle_read_only_event(
+                        app_state, key, config, form_state, login_state,
+                        register_state, &mut self.key_sequence_tracker,
+                        current_position, total_count, grpc_client,
+                        &mut self.command_message, &mut self.edit_mode_cooldown,
+                        &mut self.ideal_cursor_column,
+                    )
+                    .await?;
+                    return Ok(EventOutcome::Ok(message));
+                }
 
                 AppMode::Edit => {
-                    if config.is_exit_edit_mode(key_code, modifiers) {
-                        self.is_edit_mode = false;
-                        self.edit_mode_cooldown = true;
-
-                        let has_changes = if app_state.ui.show_login || app_state.ui.show_register{
-                            login_state.has_unsaved_changes()
-                        } else {
-                            form_state.has_unsaved_changes()
-                        };
-
-                        self.command_message = if has_changes {
-                            "Exited edit mode (unsaved changes remain)".to_string()
-                        } else {
-                            "Read-only mode".to_string()
-                        };
-
-                        terminal.set_cursor_style(SetCursorStyle::SteadyBlock)?;
-
-                        let current_input = if app_state.ui.show_login || app_state.ui.show_register{
-                            login_state.get_current_input()
-                        } else {
-                            form_state.get_current_input()
-                        };
-                        let current_cursor_pos = if app_state.ui.show_login || app_state.ui.show_register{
-                            login_state.current_cursor_pos()
-                        } else {
-                            form_state.current_cursor_pos()
-                        };
-
-                        if !current_input.is_empty() && current_cursor_pos >= current_input.len() {
-                            let new_pos = current_input.len() - 1;
-                            if app_state.ui.show_login || app_state.ui.show_register{
-                                login_state.set_current_cursor_pos(new_pos);
-                                self.ideal_cursor_column = login_state.current_cursor_pos();
-                            } else {
-                                form_state.set_current_cursor_pos(new_pos);
-                                self.ideal_cursor_column = form_state.current_cursor_pos();
-                            }
-                        }
-                        return Ok(EventOutcome::Ok(self.command_message.clone()));
-                    }
-
-                    if let Some(action) = config.get_action_for_key_in_mode(
-                        &config.keybindings.common,
-                        key_code,
-                        modifiers
-                    ) {
+                    // First, check for common actions (save, revert, etc.) that apply in Edit mode
+                    // These might take precedence or have different behavior than the edit handler
+                    if let Some(action) = config.get_common_action(key_code, modifiers) {
+                        // Handle common actions like save, revert, force_quit, save_and_quit
+                        // Ensure these actions return EventOutcome directly if they might exit the app
                         match action {
                             "save" | "force_quit" | "save_and_quit" | "revert" => {
+                                // This call likely returns EventOutcome, handle it directly
                                 return common_mode::handle_core_action(
                                     action,
                                     form_state,
@@ -370,27 +384,72 @@ impl EventHandler {
                                     total_count,
                                 ).await;
                             },
+                            // Handle other common actions if necessary
                             _ => {}
                         }
+                        // If a common action was handled but didn't return/exit,
+                        // we might want to stop further processing for this key event.
+                        // Depending on the action, you might return Ok(EventOutcome::Ok(...)) here.
+                        // For now, assume common actions either exit or don't prevent further processing.
                     }
 
-                    let message = edit::handle_edit_event(
+                    // If no common action took precedence, delegate to the edit-specific handler
+                    let edit_result = edit::handle_edit_event(
                         key,
                         config,
                         form_state,
                         login_state,
                         register_state,
                         &mut self.ideal_cursor_column,
-                        &mut self.command_message,
                         current_position,
                         total_count,
                         grpc_client,
                         app_state,
-                    ).await?;
+                    ).await;
 
-                    self.key_sequence_tracker.reset();
-                    return Ok(EventOutcome::Ok(message));
-                },
+                    match edit_result {
+                        Ok(edit::EditEventOutcome::ExitEditMode) => {
+                            // The edit handler signaled to exit the mode
+                            self.is_edit_mode = false;
+                            self.edit_mode_cooldown = true;
+                            let has_changes = if app_state.ui.show_login { login_state.has_unsaved_changes() }
+                                              else if app_state.ui.show_register { register_state.has_unsaved_changes() }
+                                              else { form_state.has_unsaved_changes() };
+                            self.command_message = if has_changes {
+                                "Exited edit mode (unsaved changes remain)".to_string()
+                            } else {
+                                "Read-only mode".to_string()
+                            };
+                            terminal.set_cursor_style(SetCursorStyle::SteadyBlock)?;
+                            // Adjust cursor position if needed
+                            let current_input = if app_state.ui.show_login { login_state.get_current_input() }
+                                                else if app_state.ui.show_register { register_state.get_current_input() }
+                                                else { form_state.get_current_input() };
+                            let current_cursor_pos = if app_state.ui.show_login { login_state.current_cursor_pos() }
+                                                     else if app_state.ui.show_register { register_state.current_cursor_pos() }
+                                                     else { form_state.current_cursor_pos() };
+                            if !current_input.is_empty() && current_cursor_pos >= current_input.len() {
+                                let new_pos = current_input.len() - 1;
+                                let target_state: &mut dyn CanvasState = if app_state.ui.show_login { login_state } else if app_state.ui.show_register { register_state } else { form_state };
+                                target_state.set_current_cursor_pos(new_pos);
+                                self.ideal_cursor_column = new_pos;
+                            }
+                            return Ok(EventOutcome::Ok(self.command_message.clone()));
+                        }
+                        Ok(edit::EditEventOutcome::Message(msg)) => {
+                            // Stay in edit mode, update message if not empty
+                            if !msg.is_empty() {
+                                self.command_message = msg;
+                            }
+                            self.key_sequence_tracker.reset(); // Reset sequence tracker on successful edit action
+                            return Ok(EventOutcome::Ok(self.command_message.clone()));
+                        }
+                        Err(e) => {
+                            // Handle error from the edit handler
+                            return Err(e);
+                        }
+                    }
+                }, // End AppMode::Edit
 
                 AppMode::Command => {
                     let outcome = command_mode::handle_command_event(

client/src/modes/handlers/mode_manager.rs

@@ -1,12 +1,14 @@
 // src/modes/handlers/mode_manager.rs
 use crate::state::app::state::AppState;
 use crate::modes::handlers::event::EventHandler;
+use crate::state::app::highlight::HighlightState;
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum AppMode {
     General,   // For intro and admin screens
     ReadOnly,  // Canvas read-only mode
     Edit,      // Canvas edit mode
+    Highlight, // Cnavas highlight/visual mode
     Command,   // Command mode overlay
 }
 
@@ -19,6 +21,10 @@ impl ModeManager {
             return AppMode::Command;
         }
 
+        if !matches!(event_handler.highlight_state, HighlightState::Off) {
+            return AppMode::Highlight;
+        }
+
         if app_state.ui.focus_outside_canvas {
             return AppMode::General;
         }
@@ -50,6 +56,10 @@ impl ModeManager {
     }
     
     pub fn can_enter_read_only_mode(current_mode: AppMode) -> bool {
-        matches!(current_mode, AppMode::Edit | AppMode::Command)
+        matches!(current_mode, AppMode::Edit | AppMode::Command | AppMode::Highlight)
+    }
+
+    pub fn can_enter_highlight_mode(current_mode: AppMode) -> bool {
+        matches!(current_mode, AppMode::ReadOnly)
     }
 }

client/src/modes/highlight.rs

@@ -0,0 +1,2 @@
+// src/client/modes/highlight.rs
+pub mod highlight;

client/src/modes/highlight/highlight.rs

@@ -0,0 +1,62 @@
+// src/modes/highlight/highlight.rs
+// (This file is intentionally simple for now, reusing ReadOnly logic)
+
+use crate::config::binds::config::Config;
+use crate::config::binds::key_sequences::KeySequenceTracker;
+use crate::services::grpc_client::GrpcClient;
+use crate::state::app::state::AppState;
+use crate::state::pages::auth::{LoginState, RegisterState};
+use crate::state::pages::form::FormState;
+use crate::modes::handlers::event::EventOutcome;
+use crate::modes::read_only; // Import the ReadOnly handler
+use crossterm::event::KeyEvent;
+
+/// Handles events when in Highlight mode.
+/// Currently, it mostly delegates to the read_only handler for movement.
+/// Exiting highlight mode is handled directly in the main event handler.
+pub async fn handle_highlight_event(
+    app_state: &mut AppState,
+    key: KeyEvent,
+    config: &Config,
+    form_state: &mut FormState,
+    login_state: &mut LoginState,
+    register_state: &mut RegisterState,
+    key_sequence_tracker: &mut KeySequenceTracker,
+    current_position: &mut u64,
+    total_count: u64,
+    grpc_client: &mut GrpcClient,
+    command_message: &mut String,
+    edit_mode_cooldown: &mut bool,
+    ideal_cursor_column: &mut usize,
+) -> Result<EventOutcome, Box<dyn std::error::Error>> {
+    // Delegate movement and other actions to the read_only handler
+    // The rendering logic will use the highlight_anchor to draw the selection
+    let (should_exit, message) = read_only::handle_read_only_event(
+        app_state,
+        key,
+        config,
+        form_state,
+        login_state,
+        register_state,
+        key_sequence_tracker,
+        current_position,
+        total_count,
+        grpc_client,
+        command_message, // Pass the message buffer
+        edit_mode_cooldown,
+        ideal_cursor_column,
+    )
+    .await?;
+
+    // ReadOnly handler doesn't return EventOutcome directly, adapt if needed
+    // For now, assume Ok outcome unless ReadOnly signals an exit (which we ignore here)
+    if should_exit {
+        // This exit is likely for the whole app, let the main loop handle it
+        // We just return the message from read_only
+        Ok(EventOutcome::Ok(message))
+    } else {
+        Ok(EventOutcome::Ok(message))
+    }
+}
+
+

client/src/modes/mod.rs

@@ -3,8 +3,10 @@ pub mod handlers;
 pub mod canvas;
 pub mod general;
 pub mod common;
+pub mod highlight;
 
 pub use handlers::*;
 pub use canvas::*;
 pub use general::*;
 pub use common::*;
+pub use highlight::*;

client/src/state/app.rs

@@ -2,3 +2,4 @@
 
 pub mod state;
 pub mod buffer;
+pub mod highlight;

client/src/state/app/highlight.rs

@@ -0,0 +1,20 @@
+// src/state/app/highlight.rs
+
+/// Represents the different states of text highlighting.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum HighlightState {
+    /// Highlighting is inactive.
+    Off,
+    /// Highlighting character by character. Stores the anchor point (line index, char index).
+    Characterwise { anchor: (usize, usize) },
+    /// Highlighting line by line. Stores the anchor line index.
+    Linewise { anchor_line: usize },
+}
+
+impl Default for HighlightState {
+    /// The default state is no highlighting.
+    fn default() -> Self {
+        HighlightState::Off
+    }
+}
+

client/src/state/pages/form.rs

@@ -2,12 +2,13 @@
 use crate::config::colors::themes::Theme;
 use ratatui::layout::Rect;
 use ratatui::Frame;
+use crate::state::app::highlight::HighlightState;
 use crate::state::pages::canvas_state::CanvasState;
 
 pub struct FormState {
     pub id: i64,
-    pub fields: Vec<String>, // Use Vec<String> for dynamic field names
-    pub values: Vec<String>, // Store field values dynamically
+    pub fields: Vec<String>,
+    pub values: Vec<String>,
     pub current_field: usize,
     pub has_unsaved_changes: bool,
     pub current_cursor_pos: usize,
@@ -33,6 +34,7 @@ impl FormState {
         area: Rect,
         theme: &Theme,
         is_edit_mode: bool,
+        highlight_state: &HighlightState,
         total_count: u64,
         current_position: u64,
     ) {
@@ -48,6 +50,7 @@ impl FormState {
             &values,
             theme,
             is_edit_mode,
+            highlight_state,
             total_count,
             current_position,
         );

client/src/ui/handlers/render.rs

@@ -21,6 +21,7 @@ use crate::state::pages::intro::IntroState;
 use crate::state::app::buffer::BufferState;
 use crate::state::app::state::AppState;
 use crate::state::pages::admin::AdminState;
+use crate::state::app::highlight::HighlightState;
 
 pub fn render_ui(
     f: &mut Frame,
@@ -33,6 +34,7 @@ pub fn render_ui(
     buffer_state: &BufferState,
     theme: &Theme,
     is_edit_mode: bool,
+    highlight_state: &HighlightState,
     total_count: u64,
     current_position: u64,
     current_dir: &str,
@@ -91,7 +93,8 @@ pub fn render_ui(
             theme,
             register_state,
             app_state,
-            register_state.current_field < 4
+            register_state.current_field < 4,
+            highlight_state,
         );
     } else if app_state.ui.show_login {
         render_login(
@@ -100,7 +103,8 @@ pub fn render_ui(
             theme,
             login_state,
             app_state,
-            login_state.current_field < 2
+            login_state.current_field < 2,
+            highlight_state,
         );
     } else if app_state.ui.show_admin {
         crate::components::admin::admin_panel::render_admin_panel(
@@ -165,6 +169,7 @@ pub fn render_ui(
             &values,
             theme,
             is_edit_mode,
+            highlight_state,
             total_count,
             current_position,
         );

client/src/ui/handlers/ui.rs

@@ -91,6 +91,7 @@ pub async fn run_ui() -> Result<(), Box<dyn std::error::Error>> {
                 &buffer_state,
                 &theme,
                 is_edit_mode,
+                &event_handler.highlight_state,
                 app_state.total_count,
                 app_state.current_position,
                 &app_state.current_dir,
@@ -108,6 +109,10 @@ pub async fn run_ui() -> Result<(), Box<dyn std::error::Error>> {
             AppMode::Edit => {
                 terminal.show_cursor()?;
             }
+            AppMode::Highlight => {
+                terminal.set_cursor_style(SetCursorStyle::SteadyBlock)?;
+                terminal.show_cursor()?;
+            }
             AppMode::ReadOnly => {
                 if !app_state.ui.focus_outside_canvas {
                     terminal.set_cursor_style(SetCursorStyle::SteadyBlock)?;