modes needs more progress

client/src/modes/canvas/edit.rs

@@ -1,5 +1,6 @@
 // src/modes/canvas/edit.rs
 
+// TODO THIS is freaking bloated with functions it never uses REFACTOR 200 LOC can be gone
 use crossterm::event::{KeyEvent, KeyCode, KeyModifiers};
 use crate::tui::terminal::{
     grpc_client::GrpcClient,

client/src/modes/common.rs

@@ -0,0 +1,3 @@
+// src/client/modes/common.rs
+pub mod command_mode;
+pub mod highlight;

client/src/modes/general/navigation.rs

@@ -0,0 +1,66 @@
+// src/modes/general/navigation.rs
+use crate::state::state::AppState;
+use crate::ui::handlers::form::FormState;
+
+pub fn move_up(app_state: &mut AppState) {
+    app_state.general.selected_item = app_state.general.selected_item.saturating_sub(1);
+}
+
+pub fn move_down(app_state: &mut AppState, item_count: usize) {
+    app_state.general.selected_item = app_state.general.selected_item.saturating_add(1);
+    if item_count > 0 {
+        app_state.general.selected_item = app_state.general.selected_item.min(item_count - 1);
+    }
+}
+
+pub fn next_option(app_state: &mut AppState, option_count: usize) {
+    app_state.general.current_option = app_state.general.current_option.saturating_add(1);
+    if option_count > 0 {
+        app_state.general.current_option = app_state.general.current_option.min(option_count - 1);
+    }
+}
+
+pub fn previous_option(app_state: &mut AppState) {
+    app_state.general.current_option = app_state.general.current_option.saturating_sub(1);
+}
+
+pub fn select(app_state: &mut AppState) {
+    app_state.ui.show_form = app_state.ui.intro_state.selected_option == 0;
+    app_state.ui.show_admin = app_state.ui.intro_state.selected_option == 1;
+    app_state.ui.show_intro = false;
+}
+
+pub fn toggle_sidebar(app_state: &mut AppState) {
+    app_state.ui.show_sidebar = !app_state.ui.show_sidebar;
+}
+
+pub fn next_field(form_state: &mut FormState) {
+    if !form_state.fields.is_empty() {
+        form_state.current_field = (form_state.current_field + 1) % form_state.fields.len();
+    }
+}
+
+pub fn prev_field(form_state: &mut FormState) {
+    if !form_state.fields.is_empty() {
+        form_state.current_field = if form_state.current_field == 0 {
+            form_state.fields.len() - 1
+        } else {
+            form_state.current_field - 1
+        };
+    }
+}
+
+pub fn handle_enter_command_mode(event_handler: &mut crate::modes::handlers::event::EventHandler) {
+    event_handler.command_mode = true;
+    event_handler.command_input.clear();
+    event_handler.command_message.clear();
+}
+
+// Helper function for bounds checking in lists
+pub fn clamp_index(selected: usize, item_count: usize) -> usize {
+    if item_count == 0 {
+        0
+    } else {
+        selected.min(item_count - 1)
+    }
+}

client/src/modes/handlers.rs

@@ -1,3 +1,3 @@
 // src/client/modes/handlers.rs
 pub mod event;
-pub mod command_mode;
+pub mod mode_manager;

client/src/modes/handlers/event.rs

@@ -1,5 +1,5 @@
 // src/modes/handlers/event.rs
-use crossterm::event::Event;
+use crossterm::event::{Event, KeyEvent};
 use crossterm::cursor::SetCursorStyle;
 use crate::tui::terminal::{
     core::TerminalCore,
@@ -10,10 +10,12 @@ use crate::config::binds::config::Config;
 use crate::ui::handlers::form::FormState;
 use crate::ui::handlers::rat_state::UiStateHandler;
 use crate::modes::{
-    handlers::{command_mode},
+    common::{command_mode},
     canvas::{edit, read_only, common},
 };
+use crate::modes::navigation;
 use crate::config::binds::key_sequences::KeySequenceTracker;
+use crate::modes::handlers::mode_manager::{ModeManager, AppMode};
 
 pub struct EventHandler {
     pub command_mode: bool,
@@ -50,100 +52,108 @@ impl EventHandler {
         total_count: u64,
         current_position: &mut u64,
     ) -> Result<(bool, String), Box<dyn std::error::Error>> {
+        // Determine current mode based on app state and event handler state
+        let current_mode = ModeManager::derive_mode(app_state, self);
+        app_state.update_mode(current_mode);
+
         if let Event::Key(key) = event {
             let key_code = key.code;
             let modifiers = key.modifiers;
 
-            // Handle general mode (replaces intro and admin)
-            if app_state.ui.show_intro || app_state.ui.show_admin {
-                if let Some(action) = config.get_general_action(key_code, modifiers) {
-                    match action {
-                        "move_up" => {
-                            app_state.general.selected_item = app_state.general.selected_item.saturating_sub(1);
-                            return Ok((false, String::new()));
-                        }
-                        "move_down" => {
-                            app_state.general.selected_item = app_state.general.selected_item.saturating_add(1);
-                            return Ok((false, String::new()));
-                        }
-                        "next_option" => {
-                            app_state.general.current_option = app_state.general.current_option.saturating_add(1);
-                            return Ok((false, String::new()));
-                        }
-                        "previous_option" => {
-                            app_state.general.current_option = app_state.general.current_option.saturating_sub(1);
-                            return Ok((false, String::new()));
-                        }
-                        "select" => {
-                            if app_state.ui.show_intro {
-                                app_state.ui.show_intro = false;
-                            } else if app_state.ui.show_admin {
-                                app_state.ui.show_admin = false;
-                            }
-                            return Ok((false, "Selected".to_string()));
-                        }
-                        "toggle_sidebar" => {
-                            app_state.ui.show_sidebar = !app_state.ui.show_sidebar;
-                            return Ok((false, format!("Sidebar {}",
-                                if app_state.ui.show_sidebar { "shown" } else { "hidden" }
-                            )));
-                        }
-                        "next_field" => {
-                            // Increment field navigation
-                            if form_state.fields.len() > 0 {
-                                form_state.current_field = (form_state.current_field + 1) % form_state.fields.len();
-                            }
-                            return Ok((false, String::new()));
-                        }
-                        "prev_field" => {
-                            // Decrement field navigation
-                            if form_state.fields.len() > 0 {
-                                form_state.current_field = if form_state.current_field == 0 {
-                                    form_state.fields.len() - 1
-                                } else {
-                                    form_state.current_field - 1
-                                };
-                            }
-                            return Ok((false, String::new()));
-                        }
-                        "enter_command_mode" => {
-                            self.command_mode = true;
-                            self.command_input.clear();
-                            self.command_message.clear();
-                            return Ok((false, String::new()));
-                        }
-                        _ => {}
-                    }
-                }
-
-                if let Some("enter_command_mode") = config.get_action_for_key_in_mode(
-                    &config.keybindings.global,
-                    key_code,
-                    modifiers
-                ) {
-                    self.command_mode = true;
-                    return Ok((false, String::new()));
-                }
-                
-                // If no general action matched, return to stay in general mode
-                return Ok((false, String::new()));
-            }
-            
-            // The rest of the function handles other modes as before
-            // Handle toggling sidebar which is common across modes
-            if UiStateHandler::toggle_sidebar(
-                &mut app_state.ui,
-                config,
-                key_code,
-                modifiers,
-            ) {
+            // Handle common actions across all modes
+            if UiStateHandler::toggle_sidebar(&mut app_state.ui, config, key_code, modifiers) {
                 return Ok((false, format!("Sidebar {}",
                     if app_state.ui.show_sidebar { "shown" } else { "hidden" }
                 )));
             }
 
-                // Handle edit mode first to allow normal character input
-                if self.is_edit_mode {
+            // Mode-specific handling
+            match current_mode {
+                AppMode::General => {
+                    return self.handle_general_mode(
+                        key,
+                        config,
+                        form_state,
+                        app_state,
+                    );
+                },
+
+                AppMode::ReadOnly => {
+                    // Check for mode transitions first
+                    if config.is_enter_edit_mode_before(key_code, modifiers) &&
+                       ModeManager::can_enter_edit_mode(current_mode) {
+                        self.is_edit_mode = true;
+                        self.edit_mode_cooldown = true;
+                        self.command_message = "Edit mode".to_string();
+                        terminal.set_cursor_style(SetCursorStyle::BlinkingBar)?;
+                        return Ok((false, self.command_message.clone()));
+                    }
+
+                    if config.is_enter_edit_mode_after(key_code, modifiers) &&
+                       ModeManager::can_enter_edit_mode(current_mode) {
+                        let current_input = form_state.get_current_input();
+                        if !current_input.is_empty() && form_state.current_cursor_pos < current_input.len() {
+                            form_state.current_cursor_pos += 1;
+                            self.ideal_cursor_column = form_state.current_cursor_pos;
+                        }
+                        self.is_edit_mode = true;
+                        self.edit_mode_cooldown = true;
+                        self.command_message = "Edit mode (after cursor)".to_string();
+                        terminal.set_cursor_style(SetCursorStyle::BlinkingBar)?;
+                        return Ok((false, self.command_message.clone()));
+                    }
+
+                    // Check for entering command mode
+                    if let Some(action) = config.get_read_only_action_for_key(key_code, modifiers) {
+                        if action == "enter_command_mode" && ModeManager::can_enter_command_mode(current_mode) {
+                            self.command_mode = true;
+                            self.command_input.clear();
+                            self.command_message.clear();
+                            return Ok((false, String::new()));
+                        }
+                    }
+
+                    // Check for core application actions (save, quit, etc.)
+                    // ONLY handle a limited subset of core actions here
+                    if let Some(action) = config.get_action_for_key_in_mode(
+                        &config.keybindings.common,
+                        key_code,
+                        modifiers
+                    ) {
+                        match action {
+                            "save" | "force_quit" | "save_and_quit" | "revert" => {
+                                return self.handle_core_action(
+                                    action,
+                                    form_state,
+                                    grpc_client,
+                                    command_handler,
+                                    terminal,
+                                    app_state,
+                                    current_position,
+                                    total_count,
+                                ).await;
+                            },
+                            _ => {} // For other actions, let the mode-specific handler take care of it
+                        }
+                    }
+
+                    // Let read_only mode handle its own actions (including navigation from common bindings)
+                    return read_only::handle_read_only_event(
+                        key,
+                        config,
+                        form_state,
+                        &mut self.key_sequence_tracker,
+                        current_position,
+                        total_count,
+                        grpc_client,
+                        &mut self.command_message,
+                        &mut self.edit_mode_cooldown,
+                        &mut self.ideal_cursor_column,
+                    ).await;
+                },
+
+                AppMode::Edit => {
+                    // Check for exiting edit mode
                     if config.is_exit_edit_mode(key_code, modifiers) {
                         if form_state.has_unsaved_changes {
                             self.command_message = "Unsaved changes! Use :w to save or :q! to discard".to_string();
@@ -162,6 +172,31 @@ impl EventHandler {
                         return Ok((false, self.command_message.clone()));
                     }
 
+                    // Check for core application actions (save, quit, etc.)
+                    // ONLY handle a limited subset of core actions here
+                    if let Some(action) = config.get_action_for_key_in_mode(
+                        &config.keybindings.common,
+                        key_code,
+                        modifiers
+                    ) {
+                        match action {
+                            "save" | "force_quit" | "save_and_quit" | "revert" => {
+                                return self.handle_core_action(
+                                    action,
+                                    form_state,
+                                    grpc_client,
+                                    command_handler,
+                                    terminal,
+                                    app_state,
+                                    current_position,
+                                    total_count,
+                                ).await;
+                            },
+                            _ => {} // For other actions, let the mode-specific handler take care of it
+                        }
+                    }
+
+                    // Let edit mode handle its own actions (including navigation from common bindings)
                     let result = edit::handle_edit_event_internal(
                         key,
                         config,
@@ -176,64 +211,9 @@ impl EventHandler {
 
                     self.key_sequence_tracker.reset();
                     return Ok((false, result));
-                }
+                },
 
-                // Global command mode activation
-                let context_action = config.get_action_for_current_context(
-                    self.is_edit_mode,
-                    self.command_mode,
-                    key_code,
-                    modifiers
-                );
-
-                // Block command mode entry from edit mode
-                if let Some("enter_command_mode") = context_action {
-                    if !self.is_edit_mode {
-                        self.command_mode = true;
-                        self.command_input.clear();
-                        self.command_message.clear();
-                        return Ok((false, String::new()));
-                    }
-                }
-
-                if let Some(action) = config.get_action_for_key_in_mode(
-                    &config.keybindings.common,
-                    key_code,
-                    modifiers
-                ) {
-                    match action {
-                        "save" => {
-                            let message = common::save(
-                                form_state,
-                                grpc_client,
-                                &mut app_state.ui.is_saved,
-                                current_position,
-                                total_count,
-                            ).await?;
-                            return Ok((false, message));
-                        },
-                        "force_quit" => {
-                            let (should_exit, message) = command_handler.handle_command("force_quit", terminal).await?;
-                            return Ok((should_exit, message));
-                        },
-                        "save_and_quit" => {
-                            let (should_exit, message) = command_handler.handle_command("save_and_quit", terminal).await?;
-                            return Ok((should_exit, message));
-                        },
-                        "revert" => {
-                            let message = common::revert(
-                                form_state,
-                                grpc_client,
-                                current_position,
-                                total_count,
-                            ).await?;
-                            return Ok((false, message));
-                        },
-                        _ => {}
-                    }
-                }
-
-                if self.command_mode {
+                AppMode::Command => {
                     let (should_exit, message, exit_command_mode) = command_mode::handle_command_event(
                         key,
                         config,
@@ -252,52 +232,115 @@ impl EventHandler {
 
                     return Ok((should_exit, message));
                 }
-
-                if let Some(action) = config.get_read_only_action_for_key(key_code, modifiers) {
-                    if action == "enter_command_mode" {
-                        self.command_mode = true;
-                        self.command_input.clear();
-                        self.command_message.clear();
-                        return Ok((false, String::new()));
-                    }
-                }
-
-                if config.is_enter_edit_mode_before(key_code, modifiers) {
-                    self.is_edit_mode = true;
-                    self.edit_mode_cooldown = true;
-                    self.command_message = "Edit mode".to_string();
-                    terminal.set_cursor_style(SetCursorStyle::BlinkingBar)?;
-                    return Ok((false, self.command_message.clone()));
-                }
-
-                if config.is_enter_edit_mode_after(key_code, modifiers) {
-                    let current_input = form_state.get_current_input();
-                    if !current_input.is_empty() && form_state.current_cursor_pos < current_input.len() {
-                        form_state.current_cursor_pos += 1;
-                        self.ideal_cursor_column = form_state.current_cursor_pos;
-                    }
-                    self.is_edit_mode = true;
-                    self.edit_mode_cooldown = true;
-                    self.command_message = "Edit mode (after cursor)".to_string();
-                    terminal.set_cursor_style(SetCursorStyle::BlinkingBar)?;
-                    return Ok((false, self.command_message.clone()));
-                }
-
-                return read_only::handle_read_only_event(
-                    key,
-                    config,
-                    form_state,
-                    &mut self.key_sequence_tracker,
-                    current_position,
-                    total_count,
-                    grpc_client,
-                    &mut self.command_message,
-                    &mut self.edit_mode_cooldown,
-                    &mut self.ideal_cursor_column,
-                ).await;
             }
+        }
 
+        // Non-key events or if no specific handler was matched
         self.edit_mode_cooldown = false;
         Ok((false, self.command_message.clone()))
     }
+
+    // Helper method for handling general mode actions
+    fn handle_general_mode(
+        &mut self,
+        key: KeyEvent,
+        config: &Config,
+        form_state: &mut FormState,
+        app_state: &mut crate::state::state::AppState,
+    ) -> Result<(bool, String), Box<dyn std::error::Error>> {
+        if let Some(action) = config.get_general_action(key.code, key.modifiers) {
+            match action {
+                "move_up" => {
+                    navigation::move_up(app_state);
+                    return Ok((false, String::new()));
+                }
+                "move_down" => {
+                    let item_count = if app_state.ui.show_intro {
+                        2 // Intro options count
+                    } else {
+                        app_state.profile_tree.profiles.len() // Admin panel items
+                    };
+                    navigation::move_down(app_state, item_count);
+                    return Ok((false, String::new()));
+                }
+                "next_option" => {
+                    navigation::next_option(app_state, 2); // Intro has 2 options
+                    return Ok((false, String::new()));
+                }
+                "previous_option" => {
+                    navigation::previous_option(app_state);
+                    return Ok((false, String::new()));
+                }
+                "select" => {
+                    navigation::select(app_state);
+                    return Ok((false, "Selected".to_string()));
+                }
+                "toggle_sidebar" => {
+                    navigation::toggle_sidebar(app_state);
+                    return Ok((false, format!("Sidebar {}",
+                        if app_state.ui.show_sidebar { "shown" } else { "hidden" }
+                    )));
+                }
+                "next_field" => {
+                    navigation::next_field(form_state);
+                    return Ok((false, String::new()));
+                }
+                "prev_field" => {
+                    navigation::prev_field(form_state);
+                    return Ok((false, String::new()));
+                }
+                "enter_command_mode" => {
+                    navigation::handle_enter_command_mode(self);
+                    return Ok((false, String::new()));
+                }
+                _ => {}
+            }
+        }
+        Ok((false, String::new()))
+    }
+
+    // Helper method for handling core application actions (not navigation)
+    async fn handle_core_action(
+        &mut self,
+        action: &str,
+        form_state: &mut FormState,
+        grpc_client: &mut GrpcClient,
+        command_handler: &mut CommandHandler,
+        terminal: &mut TerminalCore,
+        app_state: &mut crate::state::state::AppState,
+        current_position: &mut u64,
+        total_count: u64,
+    ) -> Result<(bool, String), Box<dyn std::error::Error>> {
+        match action {
+            "save" => {
+                let message = common::save(
+                    form_state,
+                    grpc_client,
+                    &mut app_state.ui.is_saved,
+                    current_position,
+                    total_count,
+                ).await?;
+                Ok((false, message))
+            },
+            "force_quit" => {
+                let (should_exit, message) = command_handler.handle_command("force_quit", terminal).await?;
+                Ok((should_exit, message))
+            },
+            "save_and_quit" => {
+                let (should_exit, message) = command_handler.handle_command("save_and_quit", terminal).await?;
+                Ok((should_exit, message))
+            },
+            "revert" => {
+                let message = common::revert(
+                    form_state,
+                    grpc_client,
+                    current_position,
+                    total_count,
+                ).await?;
+                Ok((false, message))
+            },
+            // We should never hit this case given our filtering above
+            _ => Ok((false, format!("Core action not handled: {}", action))),
+        }
+    }
 }

client/src/modes/handlers/mode_manager.rs

@@ -0,0 +1,50 @@
+// src/modes/handlers/mode_manager.rs
+use crate::state::state::AppState;
+use crate::modes::handlers::event::EventHandler;
+
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum AppMode {
+    General,   // For intro and admin screens
+    ReadOnly,  // Canvas read-only mode
+    Edit,      // Canvas edit mode
+    Command,   // Command mode overlay
+}
+
+pub struct ModeManager;
+
+impl ModeManager {
+    // Determine current mode based on app state
+    pub fn derive_mode(app_state: &AppState, event_handler: &EventHandler) -> AppMode {
+        // Command mode takes precedence if active
+        if event_handler.command_mode {
+            return AppMode::Command;
+        }
+
+        // Check UI state flags
+        if app_state.ui.show_intro || app_state.ui.show_admin {
+            AppMode::General
+        } else if app_state.ui.show_form {
+            if event_handler.is_edit_mode {
+                AppMode::Edit
+            } else {
+                AppMode::ReadOnly
+            }
+        } else {
+            // Fallback
+            AppMode::General
+        }
+    }
+    
+    // Mode transition rules
+    pub fn can_enter_command_mode(current_mode: AppMode) -> bool {
+        !matches!(current_mode, AppMode::Edit)  // Can't enter from Edit mode
+    }
+    
+    pub fn can_enter_edit_mode(current_mode: AppMode) -> bool {
+        matches!(current_mode, AppMode::ReadOnly)  // Only from ReadOnly
+    }
+    
+    pub fn can_enter_read_only_mode(current_mode: AppMode) -> bool {
+        matches!(current_mode, AppMode::Edit | AppMode::Command)
+    }
+}

client/src/modes/mod.rs

@@ -2,7 +2,9 @@
 pub mod handlers;
 pub mod canvas;
 pub mod general;
+pub mod common;
 
 pub use handlers::*;
 pub use canvas::*;
 pub use general::*;
+pub use common::*;

client/src/state/state.rs

@@ -2,12 +2,16 @@
 
 use std::env;
 use common::proto::multieko2::table_definition::ProfileTreeResponse;
+use crate::components::IntroState;
+use crate::modes::handlers::mode_manager::AppMode;
 
 pub struct UiState {
     pub show_sidebar: bool,
     pub is_saved: bool,
     pub show_intro: bool,
     pub show_admin: bool,
+    pub show_form: bool,
+    pub intro_state: IntroState,
 }
 
 pub struct GeneralState {
@@ -22,6 +26,7 @@ pub struct AppState {
     pub current_position: u64,
     pub profile_tree: ProfileTreeResponse,
     pub selected_profile: Option<String>,
+    pub current_mode: AppMode,
 
     // UI preferences
     pub ui: UiState,
@@ -39,6 +44,7 @@ impl AppState {
             current_position: 0,
             profile_tree: ProfileTreeResponse::default(),
             selected_profile: None,
+            current_mode: AppMode::General,
             ui: UiState::default(),
             general: GeneralState {
                 selected_item: 0,
@@ -55,6 +61,10 @@ impl AppState {
     pub fn update_current_position(&mut self, current_position: u64) {
         self.current_position = current_position;
     }
+
+    pub fn update_mode(&mut self, mode: AppMode) {
+        self.current_mode = mode;
+    }
 }
 
 impl Default for UiState {
@@ -64,6 +74,8 @@ impl Default for UiState {
             is_saved: false,
             show_intro: true,
             show_admin: false,
+            show_form: false,
+            intro_state: IntroState::new(),
         }
     }
 }

client/src/ui/handlers/render.rs

@@ -68,7 +68,7 @@ pub fn render_ui(
             &app_state.profile_tree, 
             &app_state.selected_profile,
         );
-    } else {
+    } else if app_state.ui.show_form {
         let (sidebar_area, form_area) = calculate_sidebar_layout(
             app_state.ui.show_sidebar,
             main_content_area
@@ -80,7 +80,7 @@ pub fn render_ui(
                 sidebar_rect, 
                 theme, 
                 &app_state.profile_tree, 
-                &app_state.selected_profile  // Remove trailing comma
+                &app_state.selected_profile
             );
         }
 
@@ -124,6 +124,8 @@ pub fn render_ui(
             total_count,
             current_position,
         );
+    } else{
+
     }
 
     render_status_line(f, root[1], current_dir, theme, is_edit_mode);