validation2 I dont know if its correct???

common/build.rs

@@ -12,6 +12,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
             ".komp_ac.table_validation.CharacterLimits",
             "#[derive(serde::Serialize, serde::Deserialize)]",
         )
+        .type_attribute(
+            ".komp_ac.table_validation.DisplayMask",
+            "#[derive(serde::Serialize, serde::Deserialize)]",
+        )
         .type_attribute(
             ".komp_ac.table_validation.TableValidationResponse",
             "#[derive(serde::Serialize, serde::Deserialize)]",

common/proto/table_validation.proto

@@ -23,9 +23,10 @@ message FieldValidation {
   CharacterLimits limits = 10;
   // Future expansion:
   // PatternRules pattern = 11;
-  // DisplayMask mask = 12;
+  DisplayMask mask = 3;
   // ExternalValidation external = 13;
   // CustomFormatter formatter = 14;
+  bool required = 4;
 }
 
 // Character length counting mode
@@ -49,6 +50,13 @@ message CharacterLimits {
   CountMode countMode = 4; // defaults to CHARS if unspecified
 }
 
+// Mask for pretty display
+message DisplayMask {
+  string pattern = 1;              // e.g., "(###) ###-####" or "####-##-##"
+  string input_char = 2;           // e.g., "#"
+  optional string template_char = 3; // e.g., "_"
+}
+
 // Service to fetch validations for a table
 service TableValidationService {
   rpc GetTableValidation(GetTableValidationRequest)

common/src/proto/komp_ac.table_validation.rs

@@ -23,14 +23,16 @@ pub struct FieldValidation {
     #[prost(string, tag = "1")]
     pub data_key: ::prost::alloc::string::String,
     /// Current: only CharacterLimits. More rules can be added later.
-    ///
-    /// Future expansion:
-    /// PatternRules pattern = 11;
-    /// DisplayMask mask = 12;
-    /// ExternalValidation external = 13;
-    /// CustomFormatter formatter = 14;
     #[prost(message, optional, tag = "10")]
     pub limits: ::core::option::Option<CharacterLimits>,
+    /// Future expansion:
+    /// PatternRules pattern = 11;
+    #[prost(message, optional, tag = "3")]
+    pub mask: ::core::option::Option<DisplayMask>,
+    /// ExternalValidation external = 13;
+    /// CustomFormatter formatter = 14;
+    #[prost(bool, tag = "4")]
+    pub required: bool,
 }
 /// Character limit validation (Validation 1)
 #[derive(serde::Serialize, serde::Deserialize)]
@@ -49,6 +51,20 @@ pub struct CharacterLimits {
     #[prost(enumeration = "CountMode", tag = "4")]
     pub count_mode: i32,
 }
+/// Mask for pretty display
+#[derive(serde::Serialize, serde::Deserialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
+pub struct DisplayMask {
+    /// e.g., "(###) ###-####" or "####-##-##"
+    #[prost(string, tag = "1")]
+    pub pattern: ::prost::alloc::string::String,
+    /// e.g., "#"
+    #[prost(string, tag = "2")]
+    pub input_char: ::prost::alloc::string::String,
+    /// e.g., "_"
+    #[prost(string, optional, tag = "3")]
+    pub template_char: ::core::option::Option<::prost::alloc::string::String>,
+}
 #[derive(serde::Serialize, serde::Deserialize)]
 #[derive(Clone, PartialEq, ::prost::Message)]
 pub struct UpdateFieldValidationRequest {

server/src/server/services/table_validation_service.rs

@@ -1,6 +1,5 @@
 // src/server/services/table_validation_service.rs
 
-use tonic::transport::Server;
 use sqlx::PgPool;
 
 use common::proto::komp_ac::table_validation::table_validation_service_server::TableValidationServiceServer;

server/src/table_definition/handlers/post_table_definition.rs

@@ -2,7 +2,6 @@
 
 use tonic::Status;
 use sqlx::{PgPool, Transaction, Postgres};
-use serde_json::json;
 use common::proto::komp_ac::table_definition::{PostTableDefinitionRequest, TableDefinitionResponse};
 use common::proto::komp_ac::table_definition::ColumnDefinition;
 use crate::table_definition::models::map_field_type;

server/src/table_script/handlers/dependency_analyzer.rs

@@ -3,7 +3,7 @@
 use std::collections::HashMap;
 use tonic::Status;
 use serde::{Deserialize, Serialize};
-use serde_json::{json, Value};
+use serde_json::Value;
 
 /// Represents the state of a node during dependency graph traversal.
 #[derive(Clone, Copy, PartialEq)]

server/src/table_validation/get/service.rs

@@ -40,12 +40,16 @@ impl TableValidationService for TableValidationSvc {
                     // Set the data_key from the database row
                     fv.data_key = r.data_key;
                     
-                    // Skip if limits are all zero
-                    if let Some(lims) = &fv.limits {
-                        if lims.min == 0 && lims.max == 0 && lims.warn_at.is_none() {
-                            continue;
-                        }
+                    // Keep entries that have either meaningful limits or a mask
+                    let has_meaningful_limits = fv
+                        .limits
+                        .as_ref()
+                        .map_or(false, |l| l.min > 0 || l.max > 0 || l.warn_at.is_some());
+                    let has_mask = fv.mask.is_some();
+                    if !has_meaningful_limits && !has_mask {
+                        continue;
                     }                    
+
                     fields_out.push(fv);
                 }
                 Err(e) => {

server/tests/table_script/comprehensive_error_scenarios_tests.rs

@@ -5,7 +5,6 @@ use server::table_script::handlers::post_table_script::post_table_script;  // Fi
 use common::proto::komp_ac::table_script::PostTableScriptRequest;
 use common::proto::komp_ac::table_definition::ColumnDefinition;
 use rstest::*;
-use serde_json::json;
 use sqlx::PgPool;
 
 /// Helper function to create a test table with specified columns

server/tests/table_script/mathematical_operations_tests.rs

@@ -5,7 +5,6 @@ use server::table_script::handlers::post_table_script::post_table_script;  // Fi
 use common::proto::komp_ac::table_script::PostTableScriptRequest;
 use common::proto::komp_ac::table_definition::ColumnDefinition;
 use rstest::*;
-use serde_json::json;
 use sqlx::PgPool;
 
 /// Helper function to create a test table with specified columns

server/tests/table_script/post_scripts_integration_tests.rs

@@ -4,7 +4,6 @@ use crate::common::setup_isolated_db;
 use server::table_script::handlers::post_table_script::post_table_script;
 use common::proto::komp_ac::table_script::{PostTableScriptRequest, TableScriptResponse};
 use common::proto::komp_ac::table_definition::ColumnDefinition;
-use serde_json::json;
 use sqlx::PgPool;
 
 /// Test utilities for table script integration testing - moved to top level for shared access

server/tests/table_script/prohibited_types_test.rs

@@ -4,7 +4,6 @@ use crate::common::setup_isolated_db;
 use server::table_script::handlers::post_table_script::post_table_script;
 use common::proto::komp_ac::table_script::PostTableScriptRequest;
 use common::proto::komp_ac::table_definition::ColumnDefinition;
-use serde_json::json;
 use sqlx::PgPool;
 
 /// Helper function to create a test table with specified columns

server/tests/table_script/type_safety_comprehensive_tests.rs

@@ -5,7 +5,6 @@ use server::table_script::handlers::post_table_script::post_table_script;
 use common::proto::komp_ac::table_script::PostTableScriptRequest;
 use common::proto::komp_ac::table_definition::ColumnDefinition;
 use rstest::*;
-use serde_json::json;
 use sqlx::PgPool;
 
 /// Test fixture for allowed mathematical types

server/tests/tables_data/delete/delete_table_data_test.rs

@@ -5,7 +5,6 @@ use sqlx::{PgPool, Row};
 use std::collections::HashMap;
 use std::sync::Arc;
 use tokio::sync::{mpsc, Mutex};
-use serde_json::json;
 use chrono::Utc;
 use futures::future::join_all;
 use prost_types::{value::Kind, Value};
@@ -17,7 +16,7 @@ use common::proto::komp_ac::table_definition::{
     PostTableDefinitionRequest, ColumnDefinition as TableColumnDefinition, TableLink,
 };
 use common::proto::komp_ac::tables_data::{
-    DeleteTableDataRequest, DeleteTableDataResponse, PostTableDataRequest, PutTableDataRequest,
+    DeleteTableDataRequest, PostTableDataRequest, PutTableDataRequest,
 };
 use server::indexer::IndexCommand;
 use server::table_definition::handlers::post_table_definition;

server/tests/tables_data/get/get_table_data_by_position_test.rs

@@ -8,7 +8,6 @@ use server::table_definition::handlers::post_table_definition;
 use server::tables_data::handlers::get_table_data_by_position;
 use crate::common::setup_test_db;
 use chrono::Utc;
-use serde_json::json;
 
 #[fixture]
 async fn pool() -> PgPool {

server/tests/tables_data/get/get_table_data_test.rs

@@ -5,14 +5,12 @@ use common::proto::komp_ac::tables_data::GetTableDataRequest;
 use crate::common::setup_test_db;
 use sqlx::{PgPool, Row};
 use tonic;
-use chrono::{DateTime, Utc};
+use chrono::Utc;
 use serde_json::json;
 use std::collections::HashMap;
 use futures::future::join_all;
 use rand::distr::Alphanumeric;
 use rand::Rng;
-use rust_decimal::Decimal;
-use rust_decimal_macros::dec;
 use server::table_definition::handlers::post_table_definition;
 use server::tables_data::handlers::post_table_data;
 use common::proto::komp_ac::table_definition::{
@@ -22,7 +20,6 @@ use common::proto::komp_ac::tables_data::PostTableDataRequest;
 use prost_types::Value;
 use prost_types::value::Kind;
 use tokio::sync::mpsc;
-use server::indexer::IndexCommand;
 
 #[fixture]
 async fn pool() -> PgPool {

server/tests/tables_data/get/get_table_data_test2.rs

@@ -795,7 +795,7 @@ async fn test_retrieve_from_nonexistent_schema() {
 #[rstest]
 #[tokio::test]
 async fn test_retrieve_with_database_connection_error() {
-    let mut closed_pool = setup_test_db().await;
+    let closed_pool = setup_test_db().await;
     closed_pool.close().await;
 
     let request = GetTableDataRequest {

server/tests/tables_data/post/post_table_data_test.rs

@@ -20,7 +20,6 @@ use server::indexer::IndexCommand;
 use sqlx::Row;
 use rand::distr::Alphanumeric;
 use rand::Rng;
-use rust_decimal::prelude::FromPrimitive;
 
 // Helper function to generate unique identifiers for test isolation
 fn generate_unique_id() -> String {
@@ -154,7 +153,7 @@ async fn test_context() -> TestContext {
 
 #[fixture]
 async fn closed_test_context() -> TestContext {
-    let mut context = test_context().await;
+    let context = test_context().await;
     context.pool.close().await;
     context
 }

server/tests/tables_data/put/put_table_data_test2.rs

@@ -5,7 +5,7 @@
 // ========================================================================
 
 // Additional imports needed for these tests
-use chrono::{DateTime, Utc};
+use chrono::Utc;
 use rust_decimal::Decimal;
 use std::str::FromStr;
 

server/tests/tables_data/put/put_table_data_test5.rs

@@ -8,7 +8,7 @@
 // This is needed for the database error test.
 #[fixture]
 async fn closed_test_context() -> TestContext {
-    let mut context = test_context().await;
+    let context = test_context().await;
     context.pool.close().await;
     context
 }