removing legacy

common/build.rs

@@ -43,10 +43,6 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         .type_attribute(".komp_ac.tables_data.GetAdjacentTableDataResponse", serde)
         .type_attribute(".komp_ac.tables_data.ResolvedTableLinkStatus", serde)
         .type_attribute(".komp_ac.tables_data.RowNavigationMode", serde)
-        .field_attribute(
-            ".komp_ac.table_definition.TableDetail.catalog_features",
-            "#[serde(default)]",
-        )
         .field_attribute(
             ".komp_ac.table_validation.FieldValidation.locked",
             "#[serde(default)]",
@@ -57,7 +53,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         )
         .field_attribute(
             ".komp_ac.table_definition.ColumnDefinition.boolean_ledger",
-            "#[serde(default, alias = \"boolean_ledger_operator\")]",
+            "#[serde(default)]",
         )
         .type_attribute(
             ".komp_ac.table_validation.CountMode",

common/proto/backup.proto

@@ -104,7 +104,6 @@ message BackupOperationResponse {
 }
 
 message BackupInfoResponse {
-  reserved 6, 22, 23, 24;
   bool success = 1;
   string output = 2;
   string server_version = 3;

common/proto/table_definition.proto

@@ -172,14 +172,12 @@ enum ModuleDataAccessDecision {
 
 message ModuleDataAccessRequest {
   string requesting_module = 1;
-  reserved 2, 3;
   ModuleDataExport data_export = 5;
   bool granted = 4;
 }
 
 message ModuleDataAccessUpdate {
   string requesting_module = 1;
-  reserved 2;
   ModuleDataExportId export_id = 4;
   ModuleDataAccessDecision decision = 3;
 }
@@ -387,8 +385,7 @@ message PutTableDefinitionRequest {
   // overwriting a newer structural or presentation change.
   int64 expected_row_version = 7;
 
-  // New physical/catalog name. Empty, or equal to table_name, keeps the
-  // current name for backwards-compatible callers.
+  // Required physical/catalog name. Use table_name to keep the current name.
   string new_table_name = 8;
 }
 
@@ -704,9 +701,6 @@ message TableDetail {
   // User-managed single-column indexes. Backend-managed indexes are omitted.
   repeated string indexes = 13;
 
-  // True when module-owned storage supports catalog-managed rows and settings.
-  bool catalog_managed = 14;
-
   // Supported catalog operations, not user permissions or a guarantee that a
   // particular request is valid. Column restrictions, locks, existing data and
   // optimistic concurrency checks still apply. Unknown values must be ignored.
@@ -938,8 +932,6 @@ enum ColumnTypeSpelling {
   // The name is the whole spelling: "text", "money", "gtin_13".
   COLUMN_TYPE_SPELLING_BARE = 0;
 
-  reserved 1;
-
   // The name takes the name of another table in the same profile:
   // "link(adresar)". The column holds that table's id, and the server creates
   // the foreign key and its index. A picker offers the profile's other tables

common/proto/table_validation.proto

@@ -192,7 +192,7 @@ message UpdateFieldValidationRequest {
   string dataKey = 3;
   FieldValidation validation = 4;
 
-  // Omitted keeps the legacy full-replacement behavior. Otherwise, only the
+  // Required. Only the
   // selected FieldValidation properties are changed; selecting an absent
   // message property deliberately removes it.
   google.protobuf.FieldMask update_mask = 5;

common/proto/tables_data.proto

@@ -199,8 +199,7 @@ message StageTableDataImportRequest {
   string import_id = 1;
   string table_name = 2;
   repeated TableDataImportRow rows = 3;
-  // Import-contract revision returned by GetTableImportDescriptor. A zero
-  // value is accepted for older clients and snapshots the current revision.
+  // Required positive import-contract revision returned by GetTableImportDescriptor.
   int64 expected_table_revision = 4;
 }
 

common/src/proto/komp_ac.table_definition.rs

@@ -349,8 +349,7 @@ pub struct PutTableDefinitionRequest {
     /// overwriting a newer structural or presentation change.
     #[prost(int64, tag = "7")]
     pub expected_row_version: i64,
-    /// New physical/catalog name. Empty, or equal to table_name, keeps the
-    /// current name for backwards-compatible callers.
+    /// Required physical/catalog name. Use table_name to keep the current name.
     #[prost(string, tag = "8")]
     pub new_table_name: ::prost::alloc::string::String,
 }
@@ -425,7 +424,7 @@ pub struct ColumnDefinition {
     /// Enables a Boolean ledger on Boolean columns. ANY means
     /// one true contribution wins; ALL means one false contribution wins.
     #[prost(enumeration = "BooleanLedgerOperator", tag = "7")]
-    #[serde(default, alias = "boolean_ledger_operator")]
+    #[serde(default)]
     pub boolean_ledger: i32,
     /// Defines this named column as a stored, read-only value copied through an
     /// existing LINK column. field_type and money metadata are inferred from the
@@ -758,14 +757,10 @@ pub struct TableDetail {
     /// User-managed single-column indexes. Backend-managed indexes are omitted.
     #[prost(string, repeated, tag = "13")]
     pub indexes: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
-    /// True when module-owned storage supports catalog-managed rows and settings.
-    #[prost(bool, tag = "14")]
-    pub catalog_managed: bool,
     /// Supported catalog operations, not user permissions or a guarantee that a
     /// particular request is valid. Column restrictions, locks, existing data and
     /// optimistic concurrency checks still apply. Unknown values must be ignored.
     #[prost(enumeration = "CatalogFeature", repeated, tag = "15")]
-    #[serde(default)]
     pub catalog_features: ::prost::alloc::vec::Vec<i32>,
 }
 #[derive(serde::Serialize, serde::Deserialize)]

common/src/proto/komp_ac.table_validation.rs

@@ -159,7 +159,7 @@ pub struct UpdateFieldValidationRequest {
     pub data_key: ::prost::alloc::string::String,
     #[prost(message, optional, tag = "4")]
     pub validation: ::core::option::Option<FieldValidation>,
-    /// Omitted keeps the legacy full-replacement behavior. Otherwise, only the
+    /// Required. Only the
     /// selected FieldValidation properties are changed; selecting an absent
     /// message property deliberately removes it.
     #[prost(message, optional, tag = "5")]

common/src/proto/komp_ac.tables_data.rs

@@ -96,8 +96,7 @@ pub struct StageTableDataImportRequest {
     pub table_name: ::prost::alloc::string::String,
     #[prost(message, repeated, tag = "3")]
     pub rows: ::prost::alloc::vec::Vec<TableDataImportRow>,
-    /// Import-contract revision returned by GetTableImportDescriptor. A zero
-    /// value is accepted for older clients and snapshots the current revision.
+    /// Required positive import-contract revision returned by GetTableImportDescriptor.
     #[prost(int64, tag = "4")]
     pub expected_table_revision: i64,
 }

komp-app/src/grpc.rs

@@ -378,7 +378,7 @@ impl GrpcClient {
             table_name,
             data_key,
             validation: Some(validation),
-            update_mask: None,
+            update_mask: Some(prost_types::FieldMask { paths: ["limits", "pattern", "allowed_values", "external_validation_enabled", "mask", "required", "locked"].into_iter().map(String::from).collect() }),
         };
         let request = self.authenticated_request(req)?;
         let resp = self

web/src/pages/add_validation/state.rs

@@ -109,7 +109,7 @@ impl ValidationForm {
             table_name,
             data_key: data_key.clone(),
             validation: Some(self.validation(locale, data_key)?),
-            update_mask: None,
+            update_mask: Some(prost_types::FieldMask { paths: ["limits", "pattern", "allowed_values", "external_validation_enabled", "mask", "required", "locked"].into_iter().map(String::from).collect() }),
         })
     }
 

web/src/pages/admin/ecb/mod.rs

@@ -28,7 +28,6 @@ pub(crate) fn router() -> Router<AppState> {
             "/admin/exchange-rates/evidence",
             post(workspace_logic::evidence),
         )
-        .route("/admin/ecb", get(workspace_logic::legacy_ecb))
         .route("/admin/ecb/provider", get(logic::page))
         // The status card on its own, for the poll that keeps it live while a
         // batch is running.

web/src/pages/admin/ecb/workspace_logic.rs

@@ -22,10 +22,6 @@ use super::{
     workspace_ui,
 };
 
-pub(crate) async fn legacy_ecb() -> Redirect {
-    Redirect::permanent("/admin/exchange-rates#providers")
-}
-
 pub(crate) async fn page(
     State(state): State<AppState>,
     headers: HeaderMap,