search with multiquery redesigned

search/src/lib.rs

@@ -1,48 +1,186 @@
-use std::collections::HashMap;
-use std::path::{Path, PathBuf};
+mod query_builder;
 
-use tantivy::collector::TopDocs;
-use tantivy::query::{
-    BooleanQuery, BoostQuery, FuzzyTermQuery, Occur, Query, QueryParser, TermQuery,
-};
-use tantivy::schema::{IndexRecordOption, Value};
-use tantivy::{Index, TantivyDocument, Term};
-use tonic::{Request, Response, Status};
+use std::collections::HashMap;
+use std::path::Path;
+use std::sync::{Arc, Mutex};
 
 use common::proto::komp_ac::search::searcher_server::Searcher;
 use common::proto::komp_ac::search::{search_response::Hit, SearchRequest, SearchResponse};
 pub use common::proto::komp_ac::search::searcher_server::SearcherServer;
-use common::search::{
-    normalize_exact_value, normalize_search_text, register_slovak_tokenizers, search_index_path,
-};
+use common::search::{register_tokenizers, search_index_path, SchemaFields};
+use query_builder::{build_master_query, ConstraintMode, SearchConstraint};
 use sqlx::{PgPool, Row};
+use tantivy::collector::TopDocs;
+use tantivy::schema::Value;
+use tantivy::{Index, IndexReader, ReloadPolicy, TantivyDocument};
+use tonic::{Request, Response, Status};
 use tracing::info;
 
 const INDEX_ROOT: &str = "./tantivy_indexes";
-const DEFAULT_RESULT_LIMIT: usize = 5;
-const SEARCH_RESULT_LIMIT: usize = 100;
-
-#[derive(Clone, Copy)]
-enum SearchMode {
-    Fuzzy,
-    Exact,
-}
+const DEFAULT_RESULT_LIMIT: usize = 25;
+const HARD_RESULT_LIMIT: usize = 200;
+const DEFAULT_LIST_LIMIT: usize = 5;
 
 pub struct SearcherService {
     pub pool: PgPool,
+    profiles: Mutex<HashMap<String, Arc<ProfileIndex>>>,
 }
 
-struct SearchScope {
+impl SearcherService {
+    pub fn new(pool: PgPool) -> Self {
+        Self {
+            pool,
+            profiles: Mutex::new(HashMap::new()),
+        }
+    }
+
+    async fn run_rpc(&self, request: Request<SearchRequest>) -> Result<Response<SearchResponse>, Status> {
+        let req = request.into_inner();
+        let normalized = normalize_request(req)?;
+
+        if !profile_exists(&self.pool, &normalized.profile_name).await? {
+            return Err(Status::not_found(format!(
+                "Profile '{}' was not found",
+                normalized.profile_name
+            )));
+        }
+
+        if let Some(table_name) = normalized.table_name.as_deref() {
+            if !table_exists(&self.pool, &normalized.profile_name, table_name).await? {
+                return Err(Status::not_found(format!(
+                    "Table '{}' was not found in profile '{}'",
+                    table_name, normalized.profile_name
+                )));
+            }
+        }
+
+        if !normalized.has_input() {
+            let Some(table_name) = normalized.table_name.as_deref() else {
+                return Err(Status::invalid_argument(
+                    "table_name is required when query is empty",
+                ));
+            };
+
+            let hits = fetch_latest_rows(
+                &self.pool,
+                &normalized.profile_name,
+                table_name,
+                normalized.limit.unwrap_or(DEFAULT_LIST_LIMIT),
+            )
+            .await?;
+            return Ok(Response::new(SearchResponse { hits }));
+        }
+
+        let index_path = search_index_path(Path::new(INDEX_ROOT), &normalized.profile_name);
+        if !index_path.exists() {
+            return Err(Status::not_found(format!(
+                "No search index found for profile '{}'",
+                normalized.profile_name
+            )));
+        }
+
+        let profile = profile_index(&self.profiles, &normalized.profile_name, &index_path)?;
+        let mut hits = run_search(
+            &self.pool,
+            &profile,
+            &normalized.profile_name,
+            normalized.table_name.as_deref(),
+            &normalized.free_query,
+            &normalized.must,
+            normalized.limit.unwrap_or(DEFAULT_RESULT_LIMIT),
+        )
+        .await?;
+
+        hits.sort_by(|left, right| right.score.total_cmp(&left.score));
+        if let Some(limit) = normalized.limit {
+            if hits.len() > limit {
+                hits.truncate(limit);
+            }
+        }
+
+        info!(
+            "search: profile={} table={:?} free='{}' constraints={} hits={}",
+            normalized.profile_name,
+            normalized.table_name,
+            normalized.free_query,
+            normalized.must.len(),
+            hits.len()
+        );
+
+        Ok(Response::new(SearchResponse { hits }))
+    }
+}
+
+struct ProfileIndex {
+    index: Index,
+    reader: IndexReader,
+    fields: SchemaFields,
+}
+
+impl ProfileIndex {
+    fn open(path: &Path) -> Result<Self, Status> {
+        let index = Index::open_in_dir(path)
+            .map_err(|e| Status::internal(format!("Failed to open index: {}", e)))?;
+        register_tokenizers(&index)
+            .map_err(|e| Status::internal(format!("Failed to register tokenizers: {}", e)))?;
+        let reader = index
+            .reader_builder()
+            .reload_policy(ReloadPolicy::OnCommitWithDelay)
+            .try_into()
+            .map_err(|e| Status::internal(format!("Failed to build index reader: {}", e)))?;
+        let fields = SchemaFields::from(&index.schema()).map_err(|e| {
+            Status::internal(format!(
+                "Search index schema mismatch. Reindex required: {}",
+                e
+            ))
+        })?;
+
+        Ok(Self {
+            index,
+            reader,
+            fields,
+        })
+    }
+}
+
+#[derive(Debug)]
+struct NormalizedSearchRequest {
     profile_name: String,
-    requested_table: Option<String>,
-    requested_column: Option<String>,
-    index_path: PathBuf,
+    table_name: Option<String>,
+    free_query: String,
+    must: Vec<SearchConstraint>,
+    limit: Option<usize>,
 }
 
-struct SearchCandidate {
-    score: f32,
-    pg_id: i64,
-    table_name: String,
+impl NormalizedSearchRequest {
+    fn has_input(&self) -> bool {
+        !self.free_query.is_empty() || !self.must.is_empty()
+    }
+}
+
+fn profile_index(
+    cache: &Mutex<HashMap<String, Arc<ProfileIndex>>>,
+    profile_name: &str,
+    path: &Path,
+) -> Result<Arc<ProfileIndex>, Status> {
+    {
+        let cache_guard = cache
+            .lock()
+            .map_err(|_| Status::internal("Profile index cache lock poisoned"))?;
+        if let Some(index) = cache_guard.get(profile_name) {
+            return Ok(index.clone());
+        }
+    }
+
+    let opened = Arc::new(ProfileIndex::open(path)?);
+    let mut cache_guard = cache
+        .lock()
+        .map_err(|_| Status::internal("Profile index cache lock poisoned"))?;
+    if let Some(index) = cache_guard.get(profile_name) {
+        return Ok(index.clone());
+    }
+    cache_guard.insert(profile_name.to_string(), opened.clone());
+    Ok(opened)
 }
 
 fn validate_identifier(value: &str, field_name: &str) -> Result<(), Status> {
@@ -78,210 +216,97 @@ async fn profile_exists(pool: &PgPool, profile_name: &str) -> Result<bool, Statu
     Ok(exists)
 }
 
-// Scope resolution
-async fn resolve_search_scope(
-    pool: &PgPool,
-    profile_name: &str,
-    requested_table: Option<&str>,
-    requested_column: Option<&str>,
-) -> Result<SearchScope, Status> {
-    validate_identifier(profile_name, "profile_name")?;
-
-    if !profile_exists(pool, profile_name).await? {
-        return Err(Status::not_found(format!(
-            "Profile '{}' was not found",
-            profile_name
-        )));
-    }
-
-    let requested_table = if let Some(table_name) =
-        requested_table.filter(|value| !value.trim().is_empty())
-    {
-        validate_identifier(table_name, "table_name")?;
-
-        let row = sqlx::query_scalar::<_, String>(
-            r#"
-            SELECT td.table_name
+async fn table_exists(pool: &PgPool, profile_name: &str, table_name: &str) -> Result<bool, Status> {
+    let exists = sqlx::query_scalar::<_, bool>(
+        r#"
+        SELECT EXISTS(
+            SELECT 1
             FROM table_definitions td
             JOIN schemas s ON td.schema_id = s.id
             WHERE s.name = $1 AND td.table_name = $2
-            "#,
         )
-        .bind(profile_name)
-        .bind(table_name)
-        .fetch_optional(pool)
-        .await
-        .map_err(|e| Status::internal(format!("Table lookup failed: {}", e)))?;
+        "#,
+    )
+    .bind(profile_name)
+    .bind(table_name)
+    .fetch_one(pool)
+    .await
+    .map_err(|e| Status::internal(format!("Table lookup failed: {}", e)))?;
+    Ok(exists)
+}
 
-        Some(row.ok_or_else(|| {
-            Status::not_found(format!(
-                "Table '{}' was not found in profile '{}'",
-                table_name, profile_name
-            ))
-        })?)
-    } else {
-        None
+fn normalize_request(req: SearchRequest) -> Result<NormalizedSearchRequest, Status> {
+    let profile_name = req.profile_name.trim();
+    if profile_name.is_empty() {
+        return Err(Status::invalid_argument("profile_name is required"));
+    }
+    validate_identifier(profile_name, "profile_name")?;
+
+    let table_name = match req.table_name.as_deref().map(str::trim) {
+        Some(table_name) if !table_name.is_empty() => {
+            validate_identifier(table_name, "table_name")?;
+            Some(table_name.to_string())
+        }
+        _ => None,
     };
 
-    let requested_column = if let Some(column_name) =
-        requested_column.filter(|value| !value.trim().is_empty())
-    {
-        validate_identifier(column_name, "column_name")?;
-        Some(column_name.to_string())
-    } else {
-        None
-    };
+    let free_query = req.free_query.trim().to_string();
+    let mut must = Vec::new();
 
-    Ok(SearchScope {
+    for constraint in req.must {
+        let column = constraint.column.trim();
+        if column.is_empty() {
+            return Err(Status::invalid_argument(
+                "constraint.column must not be empty",
+            ));
+        }
+        validate_identifier(column, "constraint.column")?;
+
+        let query = constraint.query.trim();
+        if query.is_empty() {
+            return Err(Status::invalid_argument(
+                "constraint.query must not be empty",
+            ));
+        }
+
+        must.push(SearchConstraint {
+            column: column.to_string(),
+            query: query.to_string(),
+            mode: constraint_mode_from_proto(constraint.mode),
+        });
+    }
+
+    let limit = req.limit.map(|value| (value as usize).min(HARD_RESULT_LIMIT));
+
+    Ok(NormalizedSearchRequest {
         profile_name: profile_name.to_string(),
-        requested_table,
-        requested_column,
-        index_path: search_index_path(Path::new(INDEX_ROOT), profile_name),
+        table_name,
+        free_query,
+        must,
+        limit,
     })
 }
 
-// Query building
-fn build_query(
-    index: &Index,
-    normalized_query: &str,
-    mode: SearchMode,
-    table_filter: Option<&str>,
-    column_filter: Option<&str>,
-) -> Result<Option<BooleanQuery>, Status> {
-    let schema = index.schema();
-    let table_name_field = schema
-        .get_field("table_name")
-        .map_err(|_| Status::internal("Schema is missing the 'table_name' field."))?;
-    let column_exact_field = schema
-        .get_field("column_exact")
-        .map_err(|_| Status::internal("Schema is missing the 'column_exact' field."))?;
-    let prefix_edge_field = schema
-        .get_field("prefix_edge")
-        .map_err(|_| Status::internal("Schema is missing the 'prefix_edge' field."))?;
-    let prefix_full_field = schema
-        .get_field("prefix_full")
-        .map_err(|_| Status::internal("Schema is missing the 'prefix_full' field."))?;
-    let text_ngram_field = schema
-        .get_field("text_ngram")
-        .map_err(|_| Status::internal("Schema is missing the 'text_ngram' field."))?;
-
-    let words: Vec<&str> = normalized_query.split_whitespace().collect();
-    if words.is_empty() {
-        return Ok(None);
+fn constraint_mode_from_proto(raw_mode: i32) -> ConstraintMode {
+    match raw_mode {
+        2 => ConstraintMode::Exact,
+        _ => ConstraintMode::Fuzzy,
     }
-
-    let content_query: Box<dyn Query> = if matches!(mode, SearchMode::Exact) {
-        if let Some(column_name) = column_filter {
-            let exact_term = Term::from_field_text(
-                column_exact_field,
-                &format!(
-                    "{}:{}",
-                    column_name.to_ascii_lowercase(),
-                    normalize_exact_value(normalized_query)
-                ),
-            );
-            Box::new(TermQuery::new(exact_term, IndexRecordOption::Basic))
-        } else {
-            let exact_parser = QueryParser::for_index(index, vec![prefix_full_field]);
-            let exact_query_str = if words.len() == 1 {
-                normalized_query.to_string()
-            } else {
-                format!("\"{}\"", normalized_query)
-            };
-
-            let exact_query = exact_parser
-                .parse_query(&exact_query_str)
-                .map_err(|e| Status::internal(format!("Failed to build exact query: {}", e)))?;
-            Box::new(exact_query)
-        }
-    } else {
-        let mut query_layers: Vec<(Occur, Box<dyn Query>)> = Vec::new();
-
-        // Layer 1: prefix
-        {
-            let mut must_clauses: Vec<(Occur, Box<dyn Query>)> = Vec::new();
-            for word in &words {
-                let edge_term = Term::from_field_text(prefix_edge_field, word);
-                let full_term = Term::from_field_text(prefix_full_field, word);
-
-                let per_word_query = BooleanQuery::new(vec![
-                    (
-                        Occur::Should,
-                        Box::new(TermQuery::new(edge_term, IndexRecordOption::Basic)),
-                    ),
-                    (
-                        Occur::Should,
-                        Box::new(TermQuery::new(full_term, IndexRecordOption::Basic)),
-                    ),
-                ]);
-                must_clauses.push((Occur::Must, Box::new(per_word_query)));
-            }
-
-            if !must_clauses.is_empty() {
-                let prefix_query = BooleanQuery::new(must_clauses);
-                let boosted_query = BoostQuery::new(Box::new(prefix_query), 4.0);
-                query_layers.push((Occur::Should, Box::new(boosted_query)));
-            }
-        }
-
-        // Layer 2: fuzzy
-        {
-            let last_word = words
-                .last()
-                .ok_or_else(|| Status::internal("Query normalization lost all tokens"))?;
-            let fuzzy_term = Term::from_field_text(prefix_full_field, last_word);
-            let fuzzy_query = FuzzyTermQuery::new(fuzzy_term, 2, true);
-            let boosted_query = BoostQuery::new(Box::new(fuzzy_query), 3.0);
-            query_layers.push((Occur::Should, Box::new(boosted_query)));
-        }
-
-        // Layer 3: phrase
-        if words.len() > 1 {
-            let slop_parser = QueryParser::for_index(index, vec![prefix_full_field]);
-            let slop_query_str = format!("\"{}\"~3", normalized_query);
-            if let Ok(slop_query) = slop_parser.parse_query(&slop_query_str) {
-                let boosted_query = BoostQuery::new(slop_query, 2.0);
-                query_layers.push((Occur::Should, Box::new(boosted_query)));
-            }
-        }
-
-        // Layer 4: ngram
-        {
-            let ngram_parser = QueryParser::for_index(index, vec![text_ngram_field]);
-            if let Ok(ngram_query) = ngram_parser.parse_query(normalized_query) {
-                let boosted_query = BoostQuery::new(ngram_query, 1.0);
-                query_layers.push((Occur::Should, Box::new(boosted_query)));
-            }
-        }
-
-        Box::new(BooleanQuery::new(query_layers))
-    };
-
-    let mut clauses: Vec<(Occur, Box<dyn Query>)> = vec![(Occur::Must, content_query)];
-    if let Some(table_name) = table_filter {
-        let table_term = Term::from_field_text(table_name_field, table_name);
-        clauses.push((
-            Occur::Must,
-            Box::new(TermQuery::new(table_term, IndexRecordOption::Basic)),
-        ));
-    }
-
-    Ok(Some(BooleanQuery::new(clauses)))
 }
 
-// Empty query
-async fn fetch_default_hits(
+async fn fetch_latest_rows(
     pool: &PgPool,
     profile_name: &str,
     table_name: &str,
+    limit: usize,
 ) -> Result<Vec<Hit>, Status> {
     let sql = format!(
-        "SELECT id, to_jsonb(t) AS data FROM {} t WHERE deleted = FALSE ORDER BY id DESC LIMIT {}",
-        qualify_profile_table(profile_name, table_name),
-        DEFAULT_RESULT_LIMIT
+        "SELECT id, to_jsonb(t) AS data FROM {} t WHERE deleted = FALSE ORDER BY id DESC LIMIT $1",
+        qualify_profile_table(profile_name, table_name)
     );
 
     let rows = sqlx::query(&sql)
+        .bind(limit as i64)
         .fetch_all(pool)
         .await
         .map_err(|e| Status::internal(format!("DB query for default results failed: {}", e)))?;
@@ -301,74 +326,45 @@ async fn fetch_default_hits(
         .collect())
 }
 
-// Search + hydrate
-async fn search_profile(
+async fn run_search(
     pool: &PgPool,
-    scope: &SearchScope,
-    query_str: &str,
-    mode: SearchMode,
+    profile: &ProfileIndex,
+    profile_name: &str,
+    table_filter: Option<&str>,
+    free_query: &str,
+    must: &[SearchConstraint],
+    limit: usize,
 ) -> Result<Vec<Hit>, Status> {
-    if !scope.index_path.exists() {
-        return Ok(vec![]);
-    }
-
-    let index = Index::open_in_dir(&scope.index_path)
-        .map_err(|e| Status::internal(format!("Failed to open index: {}", e)))?;
-    register_slovak_tokenizers(&index)
-        .map_err(|e| Status::internal(format!("Failed to register Slovak tokenizers: {}", e)))?;
-
-    let Some(master_query) = build_query(
-        &index,
-        &normalize_search_text(query_str),
-        mode,
-        scope.requested_table.as_deref(),
-        scope.requested_column.as_deref(),
-    )? else {
-        return Ok(vec![]);
-    };
-
-    let reader = index
-        .reader()
-        .map_err(|e| Status::internal(format!("Failed to create index reader: {}", e)))?;
-    let searcher = reader.searcher();
-    let schema = index.schema();
-    let pg_id_field = schema
-        .get_field("pg_id")
-        .map_err(|_| Status::internal("Schema is missing the 'pg_id' field."))?;
-    let table_name_field = schema
-        .get_field("table_name")
-        .map_err(|_| Status::internal("Schema is missing the 'table_name' field."))?;
+    let master_query =
+        build_master_query(&profile.index, &profile.fields, free_query, must, table_filter)?;
 
+    let searcher = profile.reader.searcher();
     let top_docs = searcher
-        .search(&master_query, &TopDocs::with_limit(SEARCH_RESULT_LIMIT))
+        .search(&*master_query, &TopDocs::with_limit(limit))
         .map_err(|e| Status::internal(format!("Search failed: {}", e)))?;
 
     if top_docs.is_empty() {
         return Ok(vec![]);
     }
 
-    let mut candidates: Vec<SearchCandidate> = Vec::new();
+    let mut candidates: Vec<(f32, i64, String)> = Vec::with_capacity(top_docs.len());
     for (score, doc_address) in top_docs {
         let doc: TantivyDocument = searcher
             .doc(doc_address)
             .map_err(|e| Status::internal(format!("Failed to retrieve document: {}", e)))?;
-        let Some(pg_id_value) = doc.get_first(pg_id_field) else {
+        let Some(pg_id) = doc
+            .get_first(profile.fields.pg_id)
+            .and_then(|value| value.as_u64())
+        else {
             continue;
         };
-        let Some(table_name_value) = doc.get_first(table_name_field) else {
+        let Some(table_name) = doc
+            .get_first(profile.fields.table_name)
+            .and_then(|value| value.as_str())
+        else {
             continue;
         };
-        let Some(pg_id) = pg_id_value.as_u64() else {
-            continue;
-        };
-        let Some(table_name) = table_name_value.as_str() else {
-            continue;
-        };
-        candidates.push(SearchCandidate {
-            score,
-            pg_id: pg_id as i64,
-            table_name: table_name.to_string(),
-        });
+        candidates.push((score, pg_id as i64, table_name.to_string()));
     }
 
     if candidates.is_empty() {
@@ -376,11 +372,11 @@ async fn search_profile(
     }
 
     let mut ids_by_table: HashMap<String, Vec<i64>> = HashMap::new();
-    for candidate in &candidates {
+    for (_, pg_id, table_name) in &candidates {
         ids_by_table
-            .entry(candidate.table_name.clone())
+            .entry(table_name.clone())
             .or_default()
-            .push(candidate.pg_id);
+            .push(*pg_id);
     }
 
     let mut content_map: HashMap<(String, i64), String> = HashMap::new();
@@ -388,7 +384,7 @@ async fn search_profile(
         validate_identifier(&table_name, "table_name")?;
         let sql = format!(
             "SELECT id, to_jsonb(t) AS data FROM {} t WHERE deleted = FALSE AND id = ANY($1)",
-            qualify_profile_table(&scope.profile_name, &table_name)
+            qualify_profile_table(profile_name, &table_name)
         );
 
         let rows = sqlx::query(&sql)
@@ -406,14 +402,14 @@ async fn search_profile(
 
     Ok(candidates
         .into_iter()
-        .filter_map(|candidate| {
+        .filter_map(|(score, pg_id, table_name)| {
             content_map
-                .get(&(candidate.table_name.clone(), candidate.pg_id))
+                .get(&(table_name.clone(), pg_id))
                 .map(|content_json| Hit {
-                    id: candidate.pg_id,
-                    score: candidate.score,
+                    id: pg_id,
+                    score,
                     content_json: content_json.clone(),
-                    table_name: candidate.table_name,
+                    table_name,
                 })
         })
         .collect())
@@ -421,86 +417,10 @@ async fn search_profile(
 
 #[tonic::async_trait]
 impl Searcher for SearcherService {
-    async fn search_table(
+    async fn search(
         &self,
         request: Request<SearchRequest>,
     ) -> Result<Response<SearchResponse>, Status> {
-        self.run_search(request, SearchMode::Fuzzy).await
-    }
-
-    async fn exact_search_table(
-        &self,
-        request: Request<SearchRequest>,
-    ) -> Result<Response<SearchResponse>, Status> {
-        self.run_search(request, SearchMode::Exact).await
-    }
-}
-
-impl SearcherService {
-    async fn run_search(
-        &self,
-        request: Request<SearchRequest>,
-        mode: SearchMode,
-    ) -> Result<Response<SearchResponse>, Status> {
-        let req = request.into_inner();
-        let profile_name = req.profile_name.trim();
-        if profile_name.is_empty() {
-            return Err(Status::invalid_argument("profile_name is required"));
-        }
-
-        // Request scope
-        let scope =
-            resolve_search_scope(
-                &self.pool,
-                profile_name,
-                req.table_name.as_deref().map(str::trim),
-                req.column_name.as_deref().map(str::trim),
-            )
-            .await?;
-
-        let query = req.query.trim();
-        if query.is_empty() {
-            // Empty query
-            let Some(table_name) = scope.requested_table.as_deref() else {
-                return Err(Status::invalid_argument(
-                    "table_name is required when query is empty",
-                ));
-            };
-
-            let hits = fetch_default_hits(&self.pool, &scope.profile_name, table_name).await?;
-            info!(
-                "Empty query for profile '{}' table '{}'. Returning {} default hits.",
-                scope.profile_name,
-                table_name,
-                hits.len()
-            );
-            return Ok(Response::new(SearchResponse { hits }));
-        }
-
-        if scope.requested_table.is_some() && !scope.index_path.exists() {
-            return Err(Status::not_found(format!(
-                "No search index found for profile '{}'",
-                scope.profile_name
-            )));
-        }
-
-        let mut hits = search_profile(&self.pool, &scope, query, mode).await?;
-        hits.sort_by(|left, right| right.score.total_cmp(&left.score));
-        if hits.len() > SEARCH_RESULT_LIMIT {
-            hits.truncate(SEARCH_RESULT_LIMIT);
-        }
-
-        info!(
-            "Processed {} search for profile '{}' (table scope: {}). Returning {} hits.",
-            match mode {
-                SearchMode::Fuzzy => "fuzzy",
-                SearchMode::Exact => "exact",
-            },
-            scope.profile_name,
-            scope.requested_table.as_deref().unwrap_or("*"),
-            hits.len()
-        );
-
-        Ok(Response::new(SearchResponse { hits }))
+        self.run_rpc(request).await
     }
 }