put working also in rstest module

This commit is contained in:
filipriec
2025-02-24 16:49:09 +01:00
parent 040794d59d
commit 70cb2be4fa

View File

@@ -1,25 +1,29 @@
// src/adresar/tests/put_adresar_test.rs // tests/adresar/put_adresar_test.rs
use rstest::{fixture, rstest};
use server::adresar::handlers::put_adresar; use server::adresar::handlers::put_adresar;
use common::proto::multieko2::adresar::{AdresarResponse, PutAdresarRequest}; use common::proto::multieko2::adresar::PutAdresarRequest;
use sqlx::{postgres::PgPoolOptions, PgPool}; use crate::common::setup_test_db;
use std::env; use sqlx::PgPool;
use tonic;
mod test_helpers { // Fixtures
use super::*; #[fixture]
async fn pool() -> PgPool {
setup_test_db().await
}
pub async fn setup_test_db() -> (PgPool, i64) { #[fixture]
dotenvy::from_filename(".env_test").ok(); async fn closed_pool(#[future] pool: PgPool) -> PgPool {
let pool = PgPoolOptions::new() let pool = pool.await;
.max_connections(5) pool.close().await;
.connect(&env::var("TEST_DATABASE_URL").unwrap()) pool
.await }
.unwrap();
sqlx::migrate!() #[fixture]
.run(&pool) async fn existing_record(#[future] pool: PgPool) -> (PgPool, i64) {
.await let pool = pool.await;
.expect("Migrations failed");
// Create a test record in the database
let record = sqlx::query!( let record = sqlx::query!(
r#" r#"
INSERT INTO adresar ( INSERT INTO adresar (
@@ -43,9 +47,10 @@ mod test_helpers {
(pool, record.id) (pool, record.id)
} }
pub fn valid_put_request(id: i64) -> PutAdresarRequest { #[fixture]
fn valid_request_template() -> PutAdresarRequest {
PutAdresarRequest { PutAdresarRequest {
id, id: 0, // This will be replaced in each test
firma: "Updated Company".into(), firma: "Updated Company".into(),
kz: "Updated KZ".into(), kz: "Updated KZ".into(),
drc: "Updated DRC".into(), drc: "Updated DRC".into(),
@@ -64,8 +69,8 @@ mod test_helpers {
} }
} }
// Helper to check database state
pub async fn assert_response_matches(pool: &PgPool, id: i64, response: &AdresarResponse) { async fn assert_response_matches(pool: &PgPool, id: i64, response: &common::proto::multieko2::adresar::AdresarResponse) {
let db_record = sqlx::query!("SELECT * FROM adresar WHERE id = $1", id) let db_record = sqlx::query!("SELECT * FROM adresar WHERE id = $1", id)
.fetch_one(pool) .fetch_one(pool)
.await .await
@@ -88,23 +93,29 @@ mod test_helpers {
assert_eq!(db_record.fax.unwrap_or_default(), response.fax); assert_eq!(db_record.fax.unwrap_or_default(), response.fax);
assert!(!db_record.deleted, "Record should not be deleted"); assert!(!db_record.deleted, "Record should not be deleted");
} }
}
// Tests
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_update_adresar_success() { async fn test_update_adresar_success(#[future] existing_record: (PgPool, i64), valid_request_template: PutAdresarRequest) {
let (pool, existing_id) = test_helpers::setup_test_db().await; let (pool, id) = existing_record.await;
let request = test_helpers::valid_put_request(existing_id);
let mut request = valid_request_template;
request.id = id;
let response = put_adresar(&pool, request).await.unwrap(); let response = put_adresar(&pool, request).await.unwrap();
assert_eq!(response.id, existing_id); assert_eq!(response.id, id);
test_helpers::assert_response_matches(&pool, existing_id, &response).await; assert_response_matches(&pool, id, &response).await;
} }
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_update_whitespace_fields() { async fn test_update_whitespace_fields(#[future] existing_record: (PgPool, i64), valid_request_template: PutAdresarRequest) {
let (pool, existing_id) = test_helpers::setup_test_db().await; let (pool, id) = existing_record.await;
let mut request = test_helpers::valid_put_request(existing_id);
let mut request = valid_request_template;
request.id = id;
request.firma = " Updated Company ".into(); request.firma = " Updated Company ".into();
request.telefon = " +421987654321 ".into(); request.telefon = " +421987654321 ".into();
@@ -115,7 +126,7 @@ async fn test_update_whitespace_fields() {
assert_eq!(response.telefon, "+421987654321"); assert_eq!(response.telefon, "+421987654321");
// Verify raw values in database // Verify raw values in database
let db_record = sqlx::query!("SELECT firma, telefon FROM adresar WHERE id = $1", existing_id) let db_record = sqlx::query!("SELECT firma, telefon FROM adresar WHERE id = $1", id)
.fetch_one(&pool) .fetch_one(&pool)
.await .await
.unwrap(); .unwrap();
@@ -124,46 +135,75 @@ async fn test_update_whitespace_fields() {
assert_eq!(db_record.telefon.unwrap(), "+421987654321"); // Trimmed assert_eq!(db_record.telefon.unwrap(), "+421987654321"); // Trimmed
} }
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_update_empty_required_field() { async fn test_update_empty_required_field(#[future] existing_record: (PgPool, i64), valid_request_template: PutAdresarRequest) {
let (pool, existing_id) = test_helpers::setup_test_db().await; let (pool, id) = existing_record.await;
let mut request = test_helpers::valid_put_request(existing_id);
let mut request = valid_request_template;
request.id = id;
request.firma = "".into(); request.firma = "".into();
let result = put_adresar(&pool, request).await; let result = put_adresar(&pool, request).await;
assert!(result.is_err()); assert!(result.is_err());
assert_eq!(result.unwrap_err().code(), tonic::Code::InvalidArgument); // Changed from Internal assert_eq!(result.unwrap_err().code(), tonic::Code::InvalidArgument);
} }
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_update_nonexistent_id() { async fn test_update_nonexistent_id(#[future] pool: PgPool) {
let (pool, _) = test_helpers::setup_test_db().await; let pool = pool.await;
let request = test_helpers::valid_put_request(9999);
let request = PutAdresarRequest {
id: 9999, // Non-existent ID
firma: "Updated Company".into(),
kz: "Updated KZ".into(),
drc: "Updated DRC".into(),
ulica: "Updated Street".into(),
psc: "67890".into(),
mesto: "Updated City".into(),
stat: "Updated Country".into(),
banka: "Updated Bank".into(),
ucet: "987654321".into(),
skladm: "Updated SkladM".into(),
ico: "87654321".into(),
kontakt: "Jane Doe".into(),
telefon: "+421987654321".into(),
skladu: "Updated SkladU".into(),
fax: "+421987654300".into(),
};
let result = put_adresar(&pool, request).await; let result = put_adresar(&pool, request).await;
assert!(result.is_err()); assert!(result.is_err());
assert_eq!(result.unwrap_err().code(), tonic::Code::Internal); assert_eq!(result.unwrap_err().code(), tonic::Code::Internal);
} }
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_update_deleted_record() { async fn test_update_deleted_record(#[future] existing_record: (PgPool, i64), valid_request_template: PutAdresarRequest) {
let (pool, existing_id) = test_helpers::setup_test_db().await; let (pool, id) = existing_record.await;
sqlx::query!("UPDATE adresar SET deleted = true WHERE id = $1", existing_id)
// Mark the record as deleted
sqlx::query!("UPDATE adresar SET deleted = true WHERE id = $1", id)
.execute(&pool) .execute(&pool)
.await .await
.unwrap(); .unwrap();
let request = test_helpers::valid_put_request(existing_id); let mut request = valid_request_template;
let result = put_adresar(&pool, request).await; request.id = id;
let result = put_adresar(&pool, request).await;
assert!(result.is_err()); assert!(result.is_err());
assert_eq!(result.unwrap_err().code(), tonic::Code::Internal); assert_eq!(result.unwrap_err().code(), tonic::Code::Internal);
} }
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_clear_optional_fields() { async fn test_clear_optional_fields(#[future] existing_record: (PgPool, i64), valid_request_template: PutAdresarRequest) {
let (pool, existing_id) = test_helpers::setup_test_db().await; let (pool, id) = existing_record.await;
let mut request = test_helpers::valid_put_request(existing_id);
let mut request = valid_request_template;
request.id = id;
request.telefon = String::new(); request.telefon = String::new();
request.ulica = String::new(); request.ulica = String::new();
@@ -174,7 +214,7 @@ async fn test_clear_optional_fields() {
assert!(response.ulica.is_empty()); assert!(response.ulica.is_empty());
// Check database contains NULL // Check database contains NULL
let db_record = sqlx::query!("SELECT telefon, ulica FROM adresar WHERE id = $1", existing_id) let db_record = sqlx::query!("SELECT telefon, ulica FROM adresar WHERE id = $1", id)
.fetch_one(&pool) .fetch_one(&pool)
.await .await
.unwrap(); .unwrap();
@@ -183,16 +223,19 @@ async fn test_clear_optional_fields() {
assert!(db_record.ulica.is_none()); assert!(db_record.ulica.is_none());
} }
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_max_length_fields() { async fn test_max_length_fields(#[future] existing_record: (PgPool, i64), valid_request_template: PutAdresarRequest) {
let (pool, existing_id) = test_helpers::setup_test_db().await; let (pool, id) = existing_record.await;
let mut request = test_helpers::valid_put_request(existing_id);
let mut request = valid_request_template;
request.id = id;
request.firma = "a".repeat(255); request.firma = "a".repeat(255);
request.telefon = "1".repeat(20); request.telefon = "1".repeat(20);
let _response = put_adresar(&pool, request).await.unwrap(); let _response = put_adresar(&pool, request).await.unwrap();
let db_record = sqlx::query!("SELECT firma, telefon FROM adresar WHERE id = $1", existing_id) let db_record = sqlx::query!("SELECT firma, telefon FROM adresar WHERE id = $1", id)
.fetch_one(&pool) .fetch_one(&pool)
.await .await
.unwrap(); .unwrap();
@@ -201,16 +244,19 @@ async fn test_max_length_fields() {
assert_eq!(db_record.telefon.unwrap().len(), 20); assert_eq!(db_record.telefon.unwrap().len(), 20);
} }
#[rstest]
#[tokio::test] #[tokio::test]
async fn test_special_characters() { async fn test_special_characters(#[future] existing_record: (PgPool, i64), valid_request_template: PutAdresarRequest) {
let (pool, existing_id) = test_helpers::setup_test_db().await; let (pool, id) = existing_record.await;
let mut request = test_helpers::valid_put_request(existing_id);
let mut request = valid_request_template;
request.id = id;
request.ulica = "Náměstí 28. října".into(); request.ulica = "Náměstí 28. října".into();
request.telefon = "+420 123-456.789".into(); request.telefon = "+420 123-456.789".into();
let _response = put_adresar(&pool, request).await.unwrap(); let _response = put_adresar(&pool, request).await.unwrap();
let db_record = sqlx::query!("SELECT ulica, telefon FROM adresar WHERE id = $1", existing_id) let db_record = sqlx::query!("SELECT ulica, telefon FROM adresar WHERE id = $1", id)
.fetch_one(&pool) .fetch_one(&pool)
.await .await
.unwrap(); .unwrap();