filipriec/komp_ac
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TCP connection creation overhead fixed by cloning once created TCP connection. Huge performance gain on login and register. Utilizing gRPC

Browse Source
This commit is contained in:
filipriec
2025-04-19 15:54:58 +02:00
parent 8b3aa5891e
commit 60ba17cfea
4 changed files with 21 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/modes/handlers/event.rs
View File

@@ -229,7 +229,7 @@ impl EventHandler {
UiContext::Login => {
let login_action_message = match index {
0 => {
login::initiate_login(login_state, app_state, self.login_result_sender.clone())
login::initiate_login(login_state, app_state, self.auth_client.clone(), self.login_result_sender.clone())
},
1 => login::back_to_main(login_state, app_state, buffer_state).await,
_ => "Invalid Login Option".to_string(),
@@ -239,7 +239,7 @@ impl EventHandler {
UiContext::Register => {
let register_action_message = match index {
0 => {
register::initiate_registration(register_state, app_state, self.register_result_sender.clone())
register::initiate_registration(register_state, app_state, self.auth_client.clone(), self.register_result_sender.clone())
},
1 => register::back_to_login(register_state, app_state, buffer_state).await,
_ => "Invalid Login Option".to_string(),

1
client/src/services/auth.rs
View File

@@ -7,6 +7,7 @@ use common::proto::multieko2::auth::{
};
use anyhow::{Context, Result};
#[derive(Clone)]
pub struct AuthClient {
client: AuthServiceClient<Channel>,
}

19
client/src/tui/functions/common/login.rs
View File

@@ -146,6 +146,7 @@ pub async fn back_to_main(
pub fn initiate_login(
login_state: &LoginState,
app_state: &mut AppState,
mut auth_client: AuthClient,
sender: mpsc::Sender<LoginResult>,
) -> String {
let username = login_state.username.clone();
@@ -166,17 +167,13 @@ pub fn initiate_login(
// 3. Spawn the login task
spawn(async move {
let login_outcome = match AuthClient::new().await {
Ok(mut auth_client) => {
match auth_client.login(username.clone(), password).await
.with_context(|| format!("Spawned login task failed for identifier: {}", username))
{
Ok(response) => LoginResult::Success(response),
Err(e) => LoginResult::Failure(format!("{}", e)),
}
}
Err(e) => LoginResult::ConnectionError(format!("Failed to create AuthClient: {}", e)),
};
// Use the passed-in (and moved) auth_client directly
let login_outcome = match auth_client.login(username.clone(), password).await
.with_context(|| format!("Spawned login task failed for identifier: {}", username))
{
Ok(response) => LoginResult::Success(response),
Err(e) => LoginResult::Failure(format!("{}", e)),
};
// Send result back to the main UI thread
if let Err(e) = sender.send(login_outcome).await {
error!("Failed to send login result: {}", e);

26
client/src/tui/functions/common/register.rs
View File

@@ -65,6 +65,7 @@ pub async fn back_to_login(
pub fn initiate_registration(
register_state: &RegisterState,
app_state: &mut AppState,
mut auth_client: AuthClient,
sender: mpsc::Sender<RegisterResult>,
) -> String {
// Clone necessary data
@@ -87,25 +88,18 @@ pub fn initiate_registration(
// 3. Spawn the registration task
spawn(async move {
let register_outcome = match AuthClient::new().await {
Ok(mut auth_client) => {
// Handle optional fields correctly for the gRPC call
let password_opt = if password.is_empty() { None } else { Some(password) };
let password_conf_opt = if password_confirmation.is_empty() { None } else { Some(password_confirmation) };
let role_opt = if role.is_empty() { None } else { Some(role) };
match auth_client.register(username.clone(), email, password_opt, password_conf_opt, role_opt).await
.with_context(|| format!("Spawned register task failed for username: {}", username))
{
Ok(response) => RegisterResult::Success(response),
Err(e) => RegisterResult::Failure(format!("{}", e)),
}
}
Err(e) => RegisterResult::ConnectionError(format!("Failed to create AuthClient: {}", e)),
let password_opt = if password.is_empty() { None } else { Some(password) };
let password_conf_opt = if password_confirmation.is_empty() { None } else { Some(password_confirmation) };
let role_opt = if role.is_empty() { None } else { Some(role) };
let register_outcome = match auth_client.register(username.clone(), email, password_opt, password_conf_opt, role_opt).await
.with_context(|| format!("Spawned register task failed for username: {}", username))
{
Ok(response) => RegisterResult::Success(response),
Err(e) => RegisterResult::Failure(format!("{}", e)),
};
// Send result back to the main UI thread
if let Err(e) = sender.send(register_outcome).await {
error!("Failed to send registration result: {}", e);
error!("Failed to send registration result: {}", e);
}
});